From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Thornber Subject: Re: [PATCH] thin_dump: added --device-id, --skip-mappings, and new output --format's Date: Thu, 17 Mar 2016 15:44:57 +0000 Message-ID: <20160317154456.GB4033@rh-vpn> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Thanos Makatos Cc: Eric Wheeler , device-mapper development List-Id: dm-devel.ids On Tue, Mar 15, 2016 at 10:59:15AM +0000, Thanos Makatos wrote: > On 15 March 2016 at 01:45, Eric Wheeler wrote: > > Hi Joe, > > > > Please review the patch below when you have a moment. I am interested in > > your feedback, and also interested in having this functionality merged > > upstream. This was written against thin-provisioning-tools.git tag > > v0.5.6. > > > > We use thin_dump on live dm-thin metadata snapshots all the time. In our > > case, we want to dump the XML for new (snapshot) volumes instead of > > dumping the entire 16gb metadata device (37.8% used) which takes ~20-30 > > minutes instead of ~5 seconds for a single volume with --device-id. > > I'm interested in extracting the mappings of a particular device, too. > In fact, I've implemented this (along with extracting the mappings in > binary format) and have only recently opened a PR: > https://github.com/jthornber/thin-provisioning-tools/pull/49. It seems > that we've replicated some work here, I'm not sure whether we're > supposed to send patches to this list or open PR on github. I've not forgotten you patches, just haven't got round to them yet.