From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH V4] IB/uverbs: Fix race between uverbs_close and remove_one Date: Thu, 17 Mar 2016 10:12:37 -0600 Message-ID: <20160317161237.GB19501@obsidianresearch.com> References: <1457795927-16634-1-git-send-email-devesh.sharma@broadcom.com> <20160312204502.GA8346@obsidianresearch.com> <20160314174814.GB5240@obsidianresearch.com> <20160315203112.GA2786@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Devesh Sharma Cc: Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Yishai Hadas List-Id: linux-rdma@vger.kernel.org On Thu, Mar 17, 2016 at 09:38:30PM +0530, Devesh Sharma wrote: > To my mind mutex is *not* solving the problem completely unless we > make it a coarser grained lock. The possible deadlock problem still > lingers around it. Review the last version I sent, with this statement in mind: > > The fundamental thing is that the ib_uverbs_free_hw_resources thread > > must wait for ib_uverbs_close's ib_uverbs_cleanup_ucontext to finish, > > if necessary, not the other way around. It sure doesn't look like it can deadlock... Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html