From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [PATCH 1/3] ib core: Make device counter infrastructure dynamic Date: Fri, 18 Mar 2016 17:51:39 +0200 Message-ID: <20160318155139.GK25216@leon.nu> References: <20160315155441.222586021@linux.com> <20160315155455.173645653@linux.com> <20160317072354.GB25216@leon.nu> <20160317081716.GD25216@leon.nu> <20160318062009.GI25216@leon.nu> Reply-To: leon-2ukJVAZIZ/Y@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Christoph Lameter Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Bloch , Jason Gunthorpe , Steve Wise , Majd Dibbiny , alonvi-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Fri, Mar 18, 2016 at 09:33:28AM -0500, Christoph Lameter wrote: > On Fri, 18 Mar 2016, Leon Romanovsky wrote: > > > It makes the stat.name check redundant. Do you have scenario in mind > > where ret == 0 and stat.name == NULL as a result of call to the > > function? > > This is a function provided by those writing the device drivers. Better > check that the function filled out at least one required value. > I don't have any objections with this code either, just worried about patch bots like we saw a couple of months before. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html