From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Petr Kulhavy <petr-Qh/3xLP0EvwAvxtiuMwx3w@public.gmane.org>
Cc: cernekee-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org
Subject: Re: [PATCH 5/5] dt/bindings: sound: new chip added into TAS571x binding
Date: Fri, 18 Mar 2016 11:20:39 -0500 [thread overview]
Message-ID: <20160318162039.GA9378@rob-hp-laptop> (raw)
In-Reply-To: <1457609100-17164-1-git-send-email-petr-Qh/3xLP0EvwAvxtiuMwx3w@public.gmane.org>
On Thu, Mar 10, 2016 at 12:25:00PM +0100, Petr Kulhavy wrote:
> This adds the TAS5721 into the TAS571x binding.
>
> Signed-off-by: Petr Kulhavy <petr-Qh/3xLP0EvwAvxtiuMwx3w@public.gmane.org>
> ---
> Documentation/devicetree/bindings/sound/tas571x.txt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/tas571x.txt b/Documentation/devicetree/bindings/sound/tas571x.txt
> index 0ac31d8..f1aade3 100644
> --- a/Documentation/devicetree/bindings/sound/tas571x.txt
> +++ b/Documentation/devicetree/bindings/sound/tas571x.txt
> @@ -1,4 +1,4 @@
> -Texas Instruments TAS5711/TAS5717/TAS5719 stereo power amplifiers
> +Texas Instruments TAS5711/TAS5717/TAS5719/TAS5721 stereo power amplifiers
>
> The codec is controlled through an I2C interface. It also has two other
> signals that can be wired up to GPIOs: reset (strongly recommended), and
> @@ -6,7 +6,7 @@ powerdown (optional).
>
> Required properties:
>
> -- compatible: "ti,tas5711", "ti,tas5717", or "ti,tas5719"
> +- compatible: "ti,tas5711", "ti,tas5717", or "ti,tas5719", "ti,tas5721"
The "or" is in the wrong place. Please reformat to 1 compatible per
line (unless more than 1 in the DT is valid).
> - reg: The I2C address of the device
> - #sound-dai-cells: must be equal to 0
>
> @@ -25,6 +25,8 @@ Optional properties:
> - PVDD_B-supply: regulator phandle for the PVDD_B supply (5711)
> - PVDD_C-supply: regulator phandle for the PVDD_C supply (5711)
> - PVDD_D-supply: regulator phandle for the PVDD_D supply (5711)
> +- DRVDD-supply: regulator phandle for the DRVDD supply (5721)
> +- PVDD-supply: regulator phandle for the PVDD supply (5721)
>
> Example:
>
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-03-18 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 11:25 [PATCH 5/5] dt/bindings: sound: new chip added into TAS571x binding Petr Kulhavy
[not found] ` <1457609100-17164-1-git-send-email-petr-Qh/3xLP0EvwAvxtiuMwx3w@public.gmane.org>
2016-03-18 16:20 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318162039.GA9378@rob-hp-laptop \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=cernekee-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=petr-Qh/3xLP0EvwAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.