From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754225AbcCRQiU (ORCPT ); Fri, 18 Mar 2016 12:38:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46479 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752787AbcCRQiR (ORCPT ); Fri, 18 Mar 2016 12:38:17 -0400 Date: Fri, 18 Mar 2016 11:38:15 -0500 From: Josh Poimboeuf To: Arnaldo Carvalho de Melo Cc: Lucas Stach , Jiri Olsa , linux-kernel@vger.kernel.org, kernel@pengutronix.de, patchwork-lst@pengutronix.de Subject: Re: [PATCH] tools lib api: respect CROSS_COMPILE for the linker Message-ID: <20160318163815.qe7f7cwzis4riwnj@treble.redhat.com> References: <1458235670-27341-1-git-send-email-l.stach@pengutronix.de> <20160318162547.GA2701@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160318162547.GA2701@redhat.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 18, 2016 at 01:25:47PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Mar 17, 2016 at 06:27:50PM +0100, Lucas Stach escreveu: > > This fixes cross compilation of libapi. > > Humm, I guess that tools/lib/subcmd/Makefile has the same problem? And > there are also other cases where LD is not being set with CROSS_COMPILE, > Jiri, is there something else at play here? > > /me needs to cross compile all this code... Yeah, I already fixed the libsubcmd issue with commit c1d45c3abd49 in tip/core/objtool. (Sorry, I probably should have CC'ed you and Jiri.) > > - Arnaldo > > > Signed-off-by: Lucas Stach > > --- > > tools/lib/api/Makefile | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tools/lib/api/Makefile b/tools/lib/api/Makefile > > index d85904dc9b38..9383bb866664 100644 > > --- a/tools/lib/api/Makefile > > +++ b/tools/lib/api/Makefile > > @@ -10,6 +10,7 @@ endif > > > > CC = $(CROSS_COMPILE)gcc > > AR = $(CROSS_COMPILE)ar > > +LD = $(CROSS_COMPILE)ld > > > > MAKEFLAGS += --no-print-directory > > > > -- > > 2.7.0 -- Josh