From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755322AbcCTLFH (ORCPT ); Sun, 20 Mar 2016 07:05:07 -0400 Received: from mail.skyhub.de ([78.46.96.112]:45424 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753871AbcCTLE7 (ORCPT ); Sun, 20 Mar 2016 07:04:59 -0400 Date: Sun, 20 Mar 2016 12:04:55 +0100 From: Borislav Petkov To: Peter Zijlstra Cc: Thomas Gleixner , LKML , Ingo Molnar , aherrmann@suse.com, jencce.kernel@gmail.com, Rui Huang Subject: Re: [PATCH 2/3] x86/topology: Fix AMD core count Message-ID: <20160320110454.GB4230@pd.tnic> References: <20160318150345.146716865@infradead.org> <20160318150538.551407299@infradead.org> <20160320103946.GL6344@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160320103946.GL6344@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 20, 2016 at 11:39:46AM +0100, Peter Zijlstra wrote: > So the AMD NB stuff in events/amd/core.c is only for Fam10, Fam15 got > its own uncore driver. (Fam10 had the uncore events through the same > counters as the core PMU with with 'fun' constraints). > > And since Fam10 isn't affected by this change in x86_max_cores, this > _should_ work out, IF that NB code knows to switch off properly when not > required. But but, amd_core_pmu_init() is called on F15h too. It only gets the different F15h event constraints and MSRs... -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.