From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755578AbcCTSqa (ORCPT ); Sun, 20 Mar 2016 14:46:30 -0400 Received: from mail.skyhub.de ([78.46.96.112]:46903 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754489AbcCTSqQ (ORCPT ); Sun, 20 Mar 2016 14:46:16 -0400 Date: Sun, 20 Mar 2016 19:46:13 +0100 From: Borislav Petkov To: Peter Zijlstra Cc: Thomas Gleixner , LKML , Ingo Molnar , aherrmann@suse.com, jencce.kernel@gmail.com, Rui Huang Subject: Re: [PATCH 2/3] x86/topology: Fix AMD core count Message-ID: <20160320184613.GF4230@pd.tnic> References: <20160318150345.146716865@infradead.org> <20160318150538.551407299@infradead.org> <20160320103946.GL6344@twins.programming.kicks-ass.net> <20160320110454.GB4230@pd.tnic> <20160320123225.GN6344@twins.programming.kicks-ass.net> <20160320124629.GY6375@twins.programming.kicks-ass.net> <20160320130925.GC4230@pd.tnic> <20160320170847.GO6344@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160320170847.GO6344@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 20, 2016 at 06:08:47PM +0100, Peter Zijlstra wrote: > On Sun, Mar 20, 2016 at 02:09:26PM +0100, Borislav Petkov wrote: > > First a question about the big picture: why is amd/core.c even > > dealing with NB counters? > > It it not, it is dealing with Fam10 NB events. > > Fam10h doesn't have NB counters. Its NB events are on the same counters > as all the other events. Its just that they have constraints. See, and I was missing something: so there's the core x86_pmu and then more PMUs get added with perf_pmu_register(). I.e., the uncore stuff, in this case. Ok, makes sense... -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.