From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahoMy-0001DW-85 for qemu-devel@nongnu.org; Sun, 20 Mar 2016 21:10:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ahoMv-0000Nn-1X for qemu-devel@nongnu.org; Sun, 20 Mar 2016 21:10:56 -0400 Date: Mon, 21 Mar 2016 11:59:47 +1100 From: David Gibson Message-ID: <20160321005947.GC16352@voom.fritz.box> References: <1457974600-13828-1-git-send-email-clg@fr.ibm.com> <20160315003942.GE15272@voom.fritz.box> <56E7C3B3.3030809@fr.ibm.com> <20160316011914.GA9032@voom> <56E92283.7020406@fr.ibm.com> <20160317024531.GM9032@voom> <56EABF1E.20605@fr.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="adJ1OR3c6QgCpb/j" Content-Disposition: inline In-Reply-To: <56EABF1E.20605@fr.ibm.com> Subject: Re: [Qemu-devel] [PATCH 00/17] ppc: preparing pnv landing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: Thomas Huth , qemu-ppc@nongnu.org, qemu-devel@nongnu.org --adJ1OR3c6QgCpb/j Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 17, 2016 at 03:28:46PM +0100, C=E9dric Le Goater wrote: > On 03/17/2016 03:45 AM, David Gibson wrote: > > On Wed, Mar 16, 2016 at 10:08:19AM +0100, C=E9dric Le Goater wrote: > >> On 03/16/2016 02:19 AM, David Gibson wrote: > >>> On Tue, Mar 15, 2016 at 09:11:31AM +0100, C=E9dric Le Goater wrote: > >>>> On 03/15/2016 01:39 AM, David Gibson wrote: > >>>>> On Mon, Mar 14, 2016 at 05:56:23PM +0100, C=E9dric Le Goater wrote: > >>>>>> Hello, > >>>>>> > >>>>>> This is a first mini-serie of patches adding support for new ppc S= PRs. > >>>>>> They were taken from Ben's larger patchset adding the ppc powernv > >>>>>> platform and they should already be useful for the pseries guest > >>>>>> migration. > >>>>>> > >>>>>> Initial patches come from : > >>>>>> > >>>>>> https://github.com/ozbenh/qemu/commits/powernv > >>>>>> > >>>>>> The changes are mostly due to the rebase on Dave's 2.6 branch: > >>>>>> > >>>>>> https://github.com/dgibson/qemu/commits/ppc-for-2.6 > >>>>>> > >>>>>> A couple more are bisect and checkpatch fixes and finally some pat= ches > >>>>>> were merge to reduce the noise. > >>>>>> > >>>>>> =20 > >>>>>> > >>>>>> The patchset is also available here:=20 > >>>>>> > >>>>>> https://github.com/legoater/qemu/commits/for-2.6 > >>>>>> > >>>>>> It was quickly tested with a pseries guest using KVM and TCG. > >>>>> > >>>>> Hmm.. do these all fix bugs with migration, or only some of them? > >>>> > >>>> Probably only some.=20 > >>>> > >>>> Initially, Thomas gave a shorter list which I expanded to a larger o= ne=20 > >>>> because of dependencies between patches and I didn't want to change = too > >>>> much what Ben had sent. You had also reviewed a few. > >>>> > >>>>> The relevance is that things to fix migration should go into 2.6, b= ut > >>>>> preparation work for powernv that doesn't fix bug shouldn't really = be > >>>>> going in now, after the soft freeze and will need to wait for 2.7. > >>>> > >>>> OK. I will rework and keep the rest for 2.7.=20 > >>> > >>> So, I'm ok with including (low risk) patches that aren't directly > >>> relevant to 2.6 if they're prereqs for patches that are relevant to > >>> 2.6. After all, reworking the patches isn't risk free either. Please > >>> mention why these patches are being included in the commit messages > >>> though. > >> > >> Sure. =20 > >> > >>>> Thomas, thanks for the review. I have identified a few things I need= =20 > >>>> to work on but may be, the patchset is still too large for 2.6 ? > >>> > >>> It's not really a question of being too large, it's that I'm nervous > >>> about applying patches which touch the core translation code > >>> (e.g. fixes to HV mode tests) during soft freeze if they're not > >>> addressing a bug that's relevant to 2.6. > >> > >> Could you please take a look at these two patches to see if they are= =20 > >> relevant for 2.6 ? From my readings, they seem to be the only ones on= =20 > >> the edge. > >> > >> 06/17 ppc: Create cpu_ppc_set_papr() helper=20 > >> 11/17 ppc: Initialize AMOR in PAPR mode =20 > >=20 > > Ok, I've replied to each of those. > >=20 > >> but it makes sense to take them if we take : > >> > >> 12/17 ppc: Fix writing to AMR/UAMOR (move hunk to 13) > >=20 > > I'm not seeing a lot of cause to put this in for 2.6. The registers > > in question are already linked up to KVM, so migration should be ok, > > and I don't believe we have real use cases which are hitting the bugs > > this patch fixes. Except... > >=20 > >> 13/17 ppc: Add POWER8 IAMR register (rework hunk) > >=20 > > ..that I guess it's kind of a pre-req for this one, which could fix real > > migration bugs. >=20 > Yes. So, I will send a v3 removing the LPCR changes in the cpu_ppc_set_pa= pr() > helper. How does that sound ?=20 Ok, sounds good. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --adJ1OR3c6QgCpb/j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW70eCAAoJEGw4ysog2bOSxsEP/iVPpui5VVlUxqSPzVYd1BpV yix5vfW8rE0ZYYe+/xs6BOehJnPeBqj492ARbPar7yfEvPH3DVzpzcp4x60EDIFi e0ZDWM2jBsSg25U8XEQ5eMXNsOmy54sGh0MvNiuekL1mWVGCQPddsW0qyRkJ1iP/ Truyl37XtPchioKQN76Mb9MCAtXiNB1SQwkgZq2v5u1HNmmP3XgpQAydYnuHytCo 3NPbRxvZPnkOKF2tw7U6HeXYQp1VkKEDJvBnJzDd0PKtbGBrocFbXg12legPyh0p h4V9JOk35MMiNDmBrJd14YRDjj+FsIairyqcLUp7crLeVkWx5JnGmDJVrN50v6Sz Q/6jKgGRLbDFu4wo20ZXDrOU37vNXAcrDlT9VvvUWRNXj7F6+0sM4YxeuQ7LeC08 PXZaJD/KcQyms0grswFqvDGpe5tmhjuRrQXFHotu4Ck8aIjgH8mD9fNmJTvM8zDL x0EQKof3kaIu0bbaK2anJx+nXJnD1hUEukxG7q93YYwMTtwzLYQsO7oQs22tguQu wWhbUBYfNdLcqkXozjTlAXN4g/aWZCI2pN+YEEHpYUPJOJbCG2LxkVFFS4keJ5mi vt0jj8NQyuvTuf/+5WvLoKAjyn01aH9G8vQjjOC3DCahCm8cccDlcQGQDOS2swe8 p6Vz5TyLZw6TQ3d7Efow =X5Gz -----END PGP SIGNATURE----- --adJ1OR3c6QgCpb/j--