From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753959AbcCUJqI (ORCPT ); Mon, 21 Mar 2016 05:46:08 -0400 Received: from mail-by2on0065.outbound.protection.outlook.com ([207.46.100.65]:34784 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751981AbcCUJqB (ORCPT ); Mon, 21 Mar 2016 05:46:01 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O4DV4H-07-EC6-02 X-M-MSG: Date: Mon, 21 Mar 2016 17:46:12 +0800 From: Huang Rui To: Peter Zijlstra CC: Borislav Petkov , Sherry Hurwitz , , , , , , Gang Long Subject: Re: [PATCH 2/3] x86/topology: Fix AMD core count Message-ID: <20160321094611.GB26555@hr-amur2> References: <20160318150345.146716865@infradead.org> <20160318150538.551407299@infradead.org> <20160318164101.GG7817@pd.tnic> <20160321030744.GA26269@hr-amur2> <20160321082129.GP6344@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160321082129.GP6344@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(199003)(164054003)(189002)(24454002)(50466002)(86362001)(2950100001)(33716001)(47776003)(92566002)(83506001)(97756001)(76176999)(50986999)(54356999)(101416001)(81166005)(77096005)(46406003)(2906002)(110136002)(87936001)(189998001)(93886004)(4001350100001)(1076002)(586003)(1096002)(11100500001)(23726003)(33656002)(1220700001)(106466001)(105586002)(5008740100001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM3PR12MB0858;H:atltwp01.amd.com;FPR:;SPF:None;MLV:sfv;A:1;MX:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: dc8b4978-9bab-4096-5dae-08d3516d9a85 X-Microsoft-Exchange-Diagnostics: 1;DM3PR12MB0858;2:dTMzfsXpwUOlzT+yps0gAeXYgGto4K0I2bKs4Y+Cj++/gwlmBBOOQLLxuiou45BrY7Q0bpb3VrCwxyh+jam6L3crRRQVoCswHVni9BtjxCtaJND1+hBeqAu8w8kkXZB5tefJYpTwf2/J8jcSEM4lMSrfpFZr/1p0wADG+hscByzqgkt61/SFYSlnVfb32mVO;3:O0++/Yu1fNbgUL4Dd4Og72GYhKL24GLXby/nWtM3aWpspl/2HdRsRHN+UU7mMXbvLjYzc4nZLDQxA0oXpCqWX/H1L90OInXLMY6KeOhIrVvG5oS8dyCs7T1YVuy2RhCC7ro3Q1RgFjeZDlwbqJjxIQhv/UlquHsE0J6M8ZDnSOGpcz7CX+FRw0/ppwO5ablQ9iKRUqjJl3OK+7uIGYMExNp9EYzWQtF4lPuAqGZaZOg=;25:xjZhx1PgUiOfSkmf6g3ycLPNS4EEKpIk92H7FXQYbUNspZ+gwfQmJxHQOKC6U7K6iEfXm55HPUv2e3nCriJh+7wAwbn4/n0gqipjU+fOJCKWa3tYGbBmwzGTZ0w1IF7kOF9TlZhT1hVzVLLC44I2trQL2JiQJsuAfCgqPcaaMiEb4PA9ZdfU4Y3kFoty55hDXpdEY4BlKlePKUqi07rlTztuHwbCudM2sib4hwRS19MvbEswwtuQRW8NMcT7GC0RqDQXHJz+1c4D/+5vTwHJcYBceYU5ssipHHAaQ0SZ5fpnEv/mUFjQa/VcEz7GTcQBHai0OAF9u5PHV7+PrllQrYsVm5Pr0euS6e7KIf61U2ZjXDtgmEP6Nr1GFq26o5tEzEKHthm4LAzswkGm7csEjI8audDb25YnJ8FtQDW1YzqogRk/+n4cDDoSTCciyTy2D10doRg6lTRtcKGCERFfYSAeCbO+1IsYSpLJPoNLD44= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM3PR12MB0858; X-Microsoft-Exchange-Diagnostics: 1;DM3PR12MB0858;20:5W74oSNlLu/qszMOVvmwkz2+mA+yn3urGLb+KszhtT6NFWwMnBLNX/VFfkJZMHk+fSRKt6/Skwtn/Ngo/bpbd98ohrfvIE2NS1+nIfm3RBIqw+L5EbE4E3WA9eSaHa1Bn4Iu2vcrYfKuLdXg88asBYB1l+IXo5IZ014R3xgKMduLjauc95XcS5GXAJJZFivr+Hw/p2qVgpJm2B8do4odELoSTurjHwUgYndYwSOR6A58ELMIKdav//i8wMoMCzqcyL96KzsIXSVA7IV45Munkb+8QSGw2yjv0J1XNbw8BdJjSX4i16qC4ThXqhB6fBVKjbpHokBKRDzW4JfDXNos2tp60guLTJt5dGzv2d7G33o2weFURqd7zmJCqWJyt8kea+ZKub+FxyiaFsLb1W142XWCr9ob09CzKPA5KtkPDKKCK+jzKm6ISJ/eeY2iPTVO+X+/uNkJ/dj7gFK2vAl0Sz35JMJyqdNb0BD3zwyyoy1yMfuQlwtsqMbqL5zKe4Gy X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13018025)(8121501046)(13015025)(13023025)(13017025)(5005006)(13024025)(10201501046)(3002001);SRVR:DM3PR12MB0858;BCL:0;PCL:0;RULEID:;SRVR:DM3PR12MB0858; X-Microsoft-Exchange-Diagnostics: 1;DM3PR12MB0858;4:Mm2kEmE3vex0DJx8E5PY5kG276Zmjjqz8U4HmAsKiLfnaflKOwrEJQe0ZxbhV4sXxnQsIlaOhicNn3qpfmF6SD990NM64l+FIjMBjKsdTpt9c78L+1x7Vgv1JF1Ew07aJfXFhc8a5ZBQ9RvuFuw2UtRa2Ewaajm4nX65aG41ZSq1xjEe/MocK36YrI6P6BiD6jZy5/rVwLMckI0s+O/ZgesbzPHGFQ+Qj6ntmokDyaR+Ct0kZrUBB6aWC/V7nsnto3/7VWJaLkUSi56JpNkCuuMUhZmvt+7/bsO6XBcDsznM6xWU7QNARa7lBdybkwEa5WpU6qwEJfZUyl39PHW9Ayyu7FLbGQjZLotjEJCzNYvjmRJ7st0chryaZasjxUrhjopVlNTzcdaG0QPWokaK8N2sS6Pu4QZ1aZCl5CAQR3WTzPg+1HyKnTtmntgz5ldZamI4DA08pTtrWrZZy1QWXQ== X-Forefront-PRVS: 0888B1D284 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM3PR12MB0858;23:rWBs/ZanV/Bfe5mX6yJUzDrkVRO2XUJIQwwtws1L+?= =?us-ascii?Q?LNn4ZXKhuuGL5cid/FGuaz1EyYmoMClxkY2YUA7CWX9zv2qVDyIhr7C3SMwR?= =?us-ascii?Q?3tmLUhKWFdmKFHh4xrF9GvvpG5JET4u9bLjfNvGwxjK+4zc2V00A/QBB/7JC?= =?us-ascii?Q?cH6sTBrR/q+a1eYc3rI4n7fWOyDK1hU7BryfeFrkE/EvBV3RMjBQEzKlfvXG?= =?us-ascii?Q?8wsgIFWhzvhUkkmcq60Fs0jhVmZ7sO2iBqXaRopOEtKvkuMRd3oThk43LrQ3?= =?us-ascii?Q?T7PXBjlO5C7I9twKmCCZdkcbD8CEurGc2oPbQyFTOYA2eOlBi2br9S+b1X5y?= =?us-ascii?Q?VobIqu0dKYSqgb3n2wTE1wUImKSqQB9oxflst+PikPZvBsxOxzxevyAs1Wki?= =?us-ascii?Q?unUbYzAhrP6rmK8atg7TRvd2jvEj8I1C4SITCKRNUKm6vrutmcvPTIhSBILY?= =?us-ascii?Q?cmxLSfWW761+HfCzCWMtyfbgF9gE3Gn/IKTvKM821z4BxXLO1Htz6jUes9jU?= =?us-ascii?Q?aeOdS1jLK8r6+62l8SdsnXGO7j2QMZRbmJrVx3ATFyYt5Pfebym4sRGUFicm?= =?us-ascii?Q?EIRsMz/kmOHMKu7Rkh967bNuJ684d5MFMvhHrlOWHdbpuMYsZCC/sxcqcEmy?= =?us-ascii?Q?zG6QdiAvUdLB4vGBWRRxN6wYfhVhX5u01b/AMnuhSCdcOqEGI+etif9OZFvL?= =?us-ascii?Q?bjFWvRrMOkfqrnrlMiGOHOts0QcccKX/n/9mLgXnBUpuTsUC12wlLYf9c9VV?= =?us-ascii?Q?PSEa6AOmDfirAzD0HrDIBARKIKGgs3H8UToLPYGLD80LGk90cg+6AdXPDqFG?= =?us-ascii?Q?YPebZf7ONQ75cDnKU4urAwGgeWYyVzBFvZTsbs0i4Bvek5XNspJSgzfvn0CH?= =?us-ascii?Q?irdB1+5B67xB8trcCLTwgnqmBMXBX8Fu20y5x6K6zZ7foYF/yM0XBVSodVGX?= =?us-ascii?Q?fRScJDAV0q5FLSw+uH4xwddJrJ5X6bUF2BVyFh9mbFu54EwYatmeSvt2eY8B?= =?us-ascii?Q?z82HjL0iwYJjbjoQ9aldRIt?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR12MB0858;5:GtTcR1tWBMe0oByL6zNJMrGm5UpktJD0D9tL3Q0YR/vkqDqlKDFqYFygMTtgclCNmkFpE7KTfAu6lprmXQZbqImtj8TF+iaS/Hm6xEPulfvV7TM/UpSJPi6n5yGAY+18L028QLQg5lcqV2qvmz9F7w==;24:HG5hLL4WzOrRZ9NupeES3q/svXXmCv8Htl6/S9vcl9wv6qPYue6KSW4ZPDNgaawCgd/Gu7TGiEtItw8K/LhuDuxd+IbE9AojmCKtHHA3zII=;20:n3BM9qlvp9LCH7Nw8UzoOe28bKxYOz6hcTXxjbRoSOesKfEngYY+KM5/rUP16omMeILc9u3ln82sia66YIzKIaC6ZsmopMTPQSRvSYpmFgQUxPWZQQujo6ezsxioCIs7NA4aiz9w7tUtwp+c39sSI1QlT2nVYmE/APTVqT5I4mHuUwfaWrFq1555sKdhi8Y0KFGSN+HEYAwyNWt2p6FQ0CXfUCtrOM8PFZ54feElhnJddAu2112c1llFZLz74O9v SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2016 09:45:54.7119 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR12MB0858 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 21, 2016 at 09:21:29AM +0100, Peter Zijlstra wrote: > On Mon, Mar 21, 2016 at 11:07:46AM +0800, Huang Rui wrote: > > > > The issue is that Linux assumes: > > > > > > > > nr_logical_cpus = nr_cores * nr_siblings > > > > > > > > But AMD reports its CU unit as 2 cores, but then sets num_smp_siblings > > > > to 2 as well. > > > But I am confused with c->x86_max_cores /= smp_num_siblings, what is > > the real meaning of c->x86_max_cores here for AMD, the whole compute > > unit numbers per socket? > > Yes, with the whole Compute Unit being the Core, each logical CPU > becomes a Thread. This is the direct consequence of using the SMT > topology to model the CU thing. > OK, maybe, we would better add a comment to explain here. :-) Thanks, Rui