From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753296AbcCUKFN (ORCPT ); Mon, 21 Mar 2016 06:05:13 -0400 Received: from mail-bl2on0080.outbound.protection.outlook.com ([65.55.169.80]:27621 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752124AbcCUKFF (ORCPT ); Mon, 21 Mar 2016 06:05:05 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O4DW0A-07-ER9-02 X-M-MSG: Date: Mon, 21 Mar 2016 18:05:16 +0800 From: Huang Rui To: Borislav Petkov CC: Sherry Hurwitz , Peter Zijlstra , , , , , , "Gang Long" Subject: Re: [PATCH 2/3] x86/topology: Fix AMD core count Message-ID: <20160321100515.GC26555@hr-amur2> References: <20160318150345.146716865@infradead.org> <20160318150538.551407299@infradead.org> <20160318164101.GG7817@pd.tnic> <20160321030744.GA26269@hr-amur2> <20160321082340.GA15904@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160321082340.GA15904@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(24454002)(189002)(199003)(164054003)(106466001)(47776003)(105586002)(33656002)(81166005)(1096002)(76176999)(46406003)(23726003)(1076002)(1220700001)(2906002)(50986999)(54356999)(5008740100001)(92566002)(33716001)(586003)(110136002)(86362001)(50466002)(19580405001)(87936001)(101416001)(83506001)(2950100001)(4001350100001)(93886004)(97756001)(189998001)(77096005)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0853;H:atltwp01.amd.com;FPR:;SPF:None;MLV:sfv;MX:1;A:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: 02b53dfd-1ab4-45bc-2e97-08d3517043c8 X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0853;2:GLBSKwgsGAXfk7j+oG/pSc0idwdcZC5yl2YWmR/D6i5z43xfn8q+kbY+f/+U1imXSdnejKtxarJyX2zlvwFX0kWZHVV9HpmK7fdIAxt2hyU4Ceal1QX1xz+JHhN6dsuijwGSA20LktknxB7qOTCW7cCGRYkrsd/uApgMv7lJKcTLJV7CedubuWJh7vXmEoJ1;3:cFQa/JqvNUwpCcM4SLy6BCxPmuQVKzK/B2bq+YchKAoT+kYrgjF85A6dhmcMg1bn7fLLtl32dr2760a/uQXIExxR7jFC5RFVReeBbqrc2P1eQy/KCPcokoRXA9/INnr6xxWhTUCZnvDF0c3STrZ2fa++2a7ki234uiXVHcWI9BHKUVhknTsjGQJva723JVEF2QA/Ql2TPKpR1xVoowFfAhHzjJG0hO5eAQ3B1wP0jM0= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0853; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0853;25:zTaJ4Kz4TfQCfHnkXQFfVQpyzrYCD9qsUZqFoP06Hbj033+SE8tyk1BF5y8w/A/1pmfzK7AP+9iOtkhqjvqBmaXpY90J4cUS6M0OzjWp7aaImIIwEvLGSTj4M/QPTPdjyS150KP1oRRz7d5bAwEq4ymhEqeh+HESZJBeB3quY1c0EWFvywI722C/0r98iJDU50885NMWcCS5gtKMzJKMdqGpcZjYEs3dOjItWHP+LSlXQ5j6wclNlSqZDy02e/8tvPKY8Gs1Q7MzojL5sHbIVZ3CKH/zNZo3tyhpWfCcFf+yaGJvkoQX8jk3nqYPRDXBiHhDeATRFTJcok5r4EkS/zi6ZEB6HVfG/wL6jJyt2N/XVavCzCdm0voldIy0v6S0OMABbrrG6u4CwSRShT7v7ncM9hFbi9xsdQ2jgPtSuO6vEeiUhcoizMZm3IHiK8TC0QxK1/stsxdv8u/4ai8Tb2OOnetiQoOuvmgzW7pxAMrYaNHUElsz+rZBV4C0bjgsDhvlkFN//bUFo/hHENhos/Lm7SWX6r0FmMvdl5SevbMn1quU9p81g/G3/cAbkrqb X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0853;20:B35CVaaFZY1KYW/BjcQTDps5f5+3+9i6BweLvqUS3eOP0edNFeh4jzegLe3D3Z5YrdWpwehzUiIU2jZBBpx87HggYaocYZX3kJ/M0ovY7RP3ovHkzDT1YkCi/8fchGi0xD8oyMHj22ttUkQPIqvF7uhSnz1pBq2e59lRXV0P2WWubYbuuhcy2KAFUFYj1svGwz9ZKYxnKcQs9YqHEzjX33P6UMwm2XSwilB58WTL39ETRT3d/QXbhbatQmcgMhLccCPgnUqPTT8RQxhCjiPqgaFEm0QI+DQjHQdXU3ftO/99e0FU6ZWOXpp8N9iiA9LGeBcAYVOC4MrkYtwYrgWi0EZ5lC6xqqPf/Gvlc6PDVbEZ/ZT9M4+YdYC8RuNDcW+dzSYoiahEfpGsJj9vuZfyFBmI5yHYsFO0i750cjDFntf6xKj5JlVKMmCLmPsFstBh+0Vpw+mw95F3fjHSkdPUwe4zeU2E5781yL1rJb5duYsJ/yOwcDpGHWB4ko1S6Fnv X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13023025)(5005006)(13024025)(13017025)(13015025)(13018025)(8121501046)(10201501046)(3002001);SRVR:CY1PR12MB0853;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0853; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0853;4:ukfem00B9ntxrTHI7hMlM0NoA2MHylnUMRsxvjwXTEucOo7nAOb2eZjdYD7SNqhh7rUDnn7Nrek3d7VtY/HsM/qM9AAysPuCD/c5iK0ImrHBFrTbjA2DbvC8Nz5pCUOqzPnldlhQ5Efces05YfltEymsE15p3dpfkHRMTKTt+/tmig/4NZ77h7I/TKXDG0eXhJAkLvbPFAj08WPUKaeaq2hc61neHZFgLCQWxH0FcNtCo5nsO4yTcYRVdk2By+CYG2v6tqi9amyNAtvAqPaHgSREcXCALPR6PbWs5SHmiEf+DShHPWnmmENDAhv5oHrM1R/kDit+Y30I4GtDEomfdP4v2qXhfytVLMrBhPTJCBbh5txJ0uXNKL8RSfABik2RAsbRGk5fciAvKXOOgZSfSUn2TDMQ7JKzwfDeW6h9Wm0PM1e9kPSnamfSugWI/x2IAJsnpDAVyNlVjId8x52veA== X-Forefront-PRVS: 0888B1D284 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR12MB0853;23:JlwKI73NnAYdA0slzb5V1vBQmgDqbmd1G6VC9SOfb?= =?us-ascii?Q?ZWwb9vNXiyynGelJeVvIUCV2rPBQ3tg8PK/9Zm9S4uzcYtliSD4PB+JcApTQ?= =?us-ascii?Q?CPIIqACaq6byUih/zKrllcXScRYHK1xe4CknRbu9k2xsTG94mF57Paj9GQSi?= =?us-ascii?Q?AksTQqMrlfHnI9ePNR21cPqFDHGhK3jNj5+josZxLg0qbcXcOPp9gMrgiVFD?= =?us-ascii?Q?osgEwtmCZ7ESy/nC5SL6RehabCRPU7G5kfxX1LE0XsZ1QWEtRo7nbPrI6Y42?= =?us-ascii?Q?2pb7gUk0qQBSxJimPNQsQ0nD+NVQdCFqGtoOwgWUiwx0YMOp7p//K3weTuAX?= =?us-ascii?Q?aVFqa7yotguWCcFaHTE+3e4p4K9hk0MsNHON2Yhu3F/eUD+pjpiDywM5xQdo?= =?us-ascii?Q?ZM/ZeGApu+l3xaHVzq5GFhpNhfvjlUv6yIva1EXM2H7Ml+QMj27bSmH6teCM?= =?us-ascii?Q?+LOV15S+GzzGvcMVe+eL7De0FSuNH0PuikMPgoIGbhcqFtFifk9VtSFFh3Hk?= =?us-ascii?Q?xuFmUQCwgaZ1ErmNY8WCqMH2kogTlYqHXCRYyvIUzo7/rngyYV/xChpoqHtK?= =?us-ascii?Q?v715RPATIftF8Sqw5bmicxD1HrEMh7Bof65yubf26JdW21SwJ55+5GnZ0srf?= =?us-ascii?Q?8oAsa7NNZh2b4LjC7QG0eAsojf/QvngbHe087DX9qOPknwgYEmDfpLFKJo8n?= =?us-ascii?Q?FdPrdd2tImU4wUv0b3ZLgeLUVvxA9qL776DCJLCeyYfitchf96NXgOZK7qfN?= =?us-ascii?Q?YMJaBwXvDjM/g+a3OlAGUOZqKTpTOeVu7wcuxDZv/Cf5XiFAwxXejmAKBhhv?= =?us-ascii?Q?Y8WOFSd7T0RvuoX4EIMuTNg9JhgSHSyGvP+q+t7dGodZes6SrXWFpH0R7UPh?= =?us-ascii?Q?bCeOkgBx+XiEltR3yqD9bd0q2YJ8wMB1wKuDk0z0iFtq3H+98xkf7SBZUR1T?= =?us-ascii?Q?/rAWjeTFAhEOY9l8kCIs3msVsat7damykNGTqZDlbHx0162/1l0mX60iCG90?= =?us-ascii?Q?DrQaFYF74IIakXB1sMBSuBR?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0853;5:rvrU1/jAcj32ek/09APQjiOT34JQwNQBHUGMOUlr1bel31kWFL0yvRcXzHgQL8mklnIjL88RoJWCq6aq2/OQKF7a8P0ntGIZH1uu0bNxWfzIZEvLICGayImXJFX0UsXcOFrydU6jzOKP5sXXA9dAaw==;24:2eysD8BTooSP24qXS+pdzCujVapX3oq9+8cj48nBrjbl/107rz5wL8JAr6Tqq/rMsAPkUv4OqsyDlWN1/ouQyZMUGdMIjtsjfPnHUDzNroo=;20:Q9iX8OA9hHkLsGY5wjS3bb86psk6pj19E0E0HwA/QNRRLZrcEXBMsw9N0kFqm4dPogWR1OtKiK800gXy/8FHs9xv4KPjKUAO55dQmezTCtTvfF/Ch4G3SvX2moys94BH/3DQH4ojdVBqspxNcp6q1mQo/+X6uc+ZGETSih6eM5BEj8VfH0WBRZ2VVTCwWusgj250TR5swa5tM7RXAdr6vF7GsVcW1LOP4+r3sN1lyLsOWn1ebNmXjLD4eixRK7Ii SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2016 10:04:59.8657 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0853 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 21, 2016 at 09:23:41AM +0100, Borislav Petkov wrote: > On Mon, Mar 21, 2016 at 11:07:46AM +0800, Huang Rui wrote: > > OK, we will find some fam15h, fam16h platforms to verify it. Please > > wait for my feedback. > > > > But I am confused with c->x86_max_cores /= smp_num_siblings, what is > > the real meaning of c->x86_max_cores here for AMD, the whole compute > > unit numbers per socket? > > Yes, it is the cores and each core can contain two or more logical > threads. In AMD speak, that's the compute unit count. We read it in > detect_ht() from CPUID(1).EBX[23:16] which is LogicalProcessorCount, > i.e., CPUID(8000_0008).ECX[NC] + 1, i.e., the number of cores. And > "cores" in BKDG speak is the number of all cores in a processor which > are distributed across compute units.... > > That's why we divide by the number of siblings, i.e., the number of > cores in a CU, in AMD speak. > > I know, it is confusing but once we're fine with the nomenclature, it'll > become as clear as day. :-) > OK, actually, there was a topology bug on Carrzio before, the thread number was detected as 1: Before: autotest@autotest-Gardenia88:~$ lscpu Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian CPU(s): 4 On-line CPU(s) list: 0-3 Thread(s) per core: 1 Core(s) per socket: 4 Socket(s): 1 NUMA node(s): 1 Vendor ID: AuthenticAMD CPU family: 21 Model: 96 Model name: AMD Eng Sample: ZM1810C1Y4381_34/18/12/06_9874 Stepping: 0 CPU MHz: 1400.000 CPU max MHz: 1800.0000 CPU min MHz: 1400.0000 BogoMIPS: 3592.19 Virtualization: AMD-V L1d cache: 32K L1i cache: 64K L2 cache: 1024K NUMA node0 CPU(s): 0-3 Now: ray@hr-ub:~/tip$ lscpu Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian CPU(s): 4 On-line CPU(s) list: 0-3 Thread(s) per core: 2 Core(s) per socket: 2 Socket(s): 1 NUMA node(s): 1 Vendor ID: AuthenticAMD CPU family: 21 Model: 96 Stepping: 0 CPU MHz: 1400.000 BogoMIPS: 3592.19 Virtualization: AMD-V L1d cache: 32K L1i cache: 96K L2 cache: 1024K NUMA node0 CPU(s): 0-3 Looks better. I will test it on fam16h machine tomorrow, if it's OK, will add my Test-by. Thanks, Rui