From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756713AbcCUPyp (ORCPT ); Mon, 21 Mar 2016 11:54:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33278 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756044AbcCUPyn (ORCPT ); Mon, 21 Mar 2016 11:54:43 -0400 Date: Mon, 21 Mar 2016 10:54:40 -0500 From: Josh Poimboeuf To: Jessica Yu Cc: Rusty Russell , Petr Mladek , Jiri Kosina , Jonathan Corbet , Miroslav Benes , linux-api@vger.kernel.org, live-patching@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v5 5/6] samples: livepatch: mark as livepatch module Message-ID: <20160321155440.etril3oddnqwnval@treble.redhat.com> References: <1458157628-8264-1-git-send-email-jeyu@redhat.com> <1458157628-8264-6-git-send-email-jeyu@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1458157628-8264-6-git-send-email-jeyu@redhat.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 16, 2016 at 03:47:07PM -0400, Jessica Yu wrote: > Mark the module as a livepatch module so that the module loader can > appropriately identify and initialize it. > > Signed-off-by: Jessica Yu > --- > samples/livepatch/livepatch-sample.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/samples/livepatch/livepatch-sample.c b/samples/livepatch/livepatch-sample.c > index fb8c861..e34f871 100644 > --- a/samples/livepatch/livepatch-sample.c > +++ b/samples/livepatch/livepatch-sample.c > @@ -89,3 +89,4 @@ static void livepatch_exit(void) > module_init(livepatch_init); > module_exit(livepatch_exit); > MODULE_LICENSE("GPL"); > +MODULE_INFO(livepatch, "Y"); This patch should probably either be before the previous patch in the series, or just squashed into it. Otherwise the sample module could fail to work between the two commits and could break bisectability. -- Josh