From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Lucas Stach <l.stach@pengutronix.de>,
Jiri Olsa <jolsa@kernel.org>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
patchwork-lst@pengutronix.de, Wang Nan <wangnan0@huawei.com>,
acme@kernel.org
Subject: Re: [PATCH] tools lib api: respect CROSS_COMPILE for the linker
Date: Mon, 21 Mar 2016 17:40:30 -0300 [thread overview]
Message-ID: <20160321204030.GB2468@redhat.com> (raw)
In-Reply-To: <20160321080852.GC3788@krava.brq.redhat.com>
Em Mon, Mar 21, 2016 at 09:08:52AM +0100, Jiri Olsa escreveu:
> On Fri, Mar 18, 2016 at 02:38:52PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Mar 18, 2016 at 12:16:23PM -0500, Josh Poimboeuf escreveu:
> > > So 'allow-override' would probably be a good option.
> > Humm, my preference is to make tools/ look like the kernel, and the
> > kernel doesn't use that allow-override thing, right? So perhaps add what
> > is missing to make it look exactly like the kernel and then ditch this
> > allow-override thing?
> Steven explained his reason for allow-override in the comment above it,
> please make sure the new solution follows that
Sure, and I'm no make guru, but what puzzles me is why isn't this
required in:
[acme@jouet linux]$ grep -w ^CC Makefile
CC = $(CROSS_COMPILE)gcc
[acme@jouet linux]$
> > What about having all this in a single place in tools/script/?
>
> maybe tools/script/Makefile.comp
But then we would have to include multiple files in each Makefile,
perhaps it would be better to stash this in
tools/scripts/Makefile.include, that way we wouldn't have to include
any new file.
- Arnaldo
P.S.
While looking at the main kernel Makefile git history I found goodies we
could use in tools/, like:
commit 84336466011c589b6af554f2f2f1fcfa1a5c1437
Author: Roland McGrath <roland@redhat.com>
Date: Mon Dec 21 16:24:06 2009 -0800
kconfig CROSS_COMPILE option
-------------------------------------------------------------------------
And also by trying hard to mimic (preferrably use a exact copy) the kernel we
can avoid suffering from subtle stuff like:
commit 2331d1a6cd3d6e580bc88b9a160066d9e1177fe1
Author: Sam Ravnborg <sam@ravnborg.org>
Date: Sun Oct 11 23:22:58 2009 +0200
kbuild: revert "save ARCH & CROSS_COMPILE ..."
-------------------------------------------------------------------------
next prev parent reply other threads:[~2016-03-21 20:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 17:27 [PATCH] tools lib api: respect CROSS_COMPILE for the linker Lucas Stach
2016-03-18 16:25 ` Arnaldo Carvalho de Melo
2016-03-18 16:38 ` Josh Poimboeuf
2016-03-18 16:43 ` Josh Poimboeuf
2016-03-18 17:39 ` Arnaldo Carvalho de Melo
2016-03-18 16:45 ` Arnaldo Carvalho de Melo
2016-03-18 17:16 ` Josh Poimboeuf
2016-03-18 17:38 ` Arnaldo Carvalho de Melo
2016-03-18 17:42 ` Josh Poimboeuf
2016-03-21 8:08 ` Jiri Olsa
2016-03-21 20:40 ` Arnaldo Carvalho de Melo [this message]
2016-03-22 7:10 ` Jiri Olsa
2016-03-22 12:50 ` Steven Rostedt
2016-03-22 14:42 ` Arnaldo Carvalho de Melo
2016-03-22 18:22 ` David Sharp
2016-03-22 18:38 ` David Sharp
2016-06-01 9:18 ` Lucas Stach
2016-06-01 13:07 ` Arnaldo Carvalho de Melo
2016-06-08 8:37 ` [tip:perf/core] tools lib api: Respect " tip-bot for Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160321204030.GB2468@redhat.com \
--to=acme@redhat.com \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=patchwork-lst@pengutronix.de \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.