From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759290AbcCVNUJ (ORCPT ); Tue, 22 Mar 2016 09:20:09 -0400 Received: from smtprelay0020.hostedemail.com ([216.40.44.20]:38035 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758448AbcCVNUC (ORCPT ); Tue, 22 Mar 2016 09:20:02 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::,RULES_HIT:41:69:355:379:541:560:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2198:2199:2200:2393:2553:2559:2562:2693:2892:2895:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:3870:3871:3874:4321:5007:6120:6261:7875:8603:10004:10400:10450:10455:10848:10967:11232:11658:11914:12043:12109:12291:12296:12517:12519:12555:12663:12683:12740:13069:13311:13357:13439:14181:14659:14721:19904:19999:21067:21080:30054:30070:30075:30079:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: rule34_745f749648a1c X-Filterd-Recvd-Size: 2433 Date: Tue, 22 Mar 2016 09:19:56 -0400 From: Steven Rostedt To: Peter Xu Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH trace-cmd 2/2] trace-recorder: better error handling during copy Message-ID: <20160322091956.2c42eefe@gandalf.local.home> In-Reply-To: <1458632442-6878-3-git-send-email-peterx@redhat.com> References: <1458632442-6878-1-git-send-email-peterx@redhat.com> <1458632442-6878-3-git-send-email-peterx@redhat.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 22 Mar 2016 09:14:33 -0400 Peter Xu wrote: > Currently we have two ways to copy data, one is splice, one is read + > write. For both, dump more information when we got errors during the > copy. Also, when we update_fd(), we should make sure all bytes written, > and update written bytes only. > > These information might be important to better diagnose when the copy > got wrong, like no space error, or connection error when copying data to > remote sockets. In the past, we just got silence errors without notice. > > Signed-off-by: Peter Xu > --- > trace-recorder.c | 34 ++++++++++++++++++++++++---------- > 1 file changed, 24 insertions(+), 10 deletions(-) > > diff --git a/trace-recorder.c b/trace-recorder.c > index 49b04ea..7d6feb0 100644 > --- a/trace-recorder.c > +++ b/trace-recorder.c > @@ -334,13 +334,14 @@ static inline void update_fd(struct tracecmd_recorder *recorder, int size) > */ > static long splice_data(struct tracecmd_recorder *recorder) > { > - long ret; > + long ret, written; > > ret = splice(recorder->trace_fd, NULL, recorder->brass[1], NULL, > recorder->page_size, 1 /* SPLICE_F_MOVE */); > if (ret < 0) { > if (errno != EAGAIN && errno != EINTR) { > - warning("recorder error in splice input"); > + warning("recorder error in splice input: %s", > + strerror(errno)); I'm wondering if we should add a "pwarning()" helper function that will do the stderror(error) for us. -- Steve > return -1; > }