From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v3 05/10] qede: Add core driver Date: Tue, 22 Mar 2016 10:55:54 +0000 Message-ID: <20160322105554.GA19248@bricha3-MOBL3> References: <1458348805-32648-1-git-send-email-rasesh.mody@qlogic.com> <1458348805-32648-6-git-send-email-rasesh.mody@qlogic.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: thomas.monjalon@6wind.com, dev@dpdk.org, ameen.rahman@qlogic.com, harish.patil@qlogic.com, sony.chacko@qlogic.com To: Rasesh Mody Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id ED4C72BB4 for ; Tue, 22 Mar 2016 11:55:58 +0100 (CET) Content-Disposition: inline In-Reply-To: <1458348805-32648-6-git-send-email-rasesh.mody@qlogic.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Mar 18, 2016 at 05:53:20PM -0700, Rasesh Mody wrote: > Signed-off-by: Harish Patil > Signed-off-by: Rasesh Mody > Signed-off-by: Sony Chacko > --- > drivers/net/qede/Makefile | 90 +++ > drivers/net/qede/qede_eth_if.h | 176 +++++ > drivers/net/qede/qede_ethdev.c | 957 +++++++++++++++++++++++ > drivers/net/qede/qede_ethdev.h | 156 ++++ > drivers/net/qede/qede_if.h | 155 ++++ > drivers/net/qede/qede_logs.h | 93 +++ > drivers/net/qede/qede_main.c | 548 ++++++++++++++ > drivers/net/qede/qede_rxtx.c | 1172 +++++++++++++++++++++++++++++ > drivers/net/qede/qede_rxtx.h | 187 +++++ > drivers/net/qede/rte_pmd_qede_version.map | 4 + > 10 files changed, 3538 insertions(+) > create mode 100644 drivers/net/qede/Makefile > create mode 100644 drivers/net/qede/qede_eth_if.h > create mode 100644 drivers/net/qede/qede_ethdev.c > create mode 100644 drivers/net/qede/qede_ethdev.h > create mode 100644 drivers/net/qede/qede_if.h > create mode 100644 drivers/net/qede/qede_logs.h > create mode 100644 drivers/net/qede/qede_main.c > create mode 100644 drivers/net/qede/qede_rxtx.c > create mode 100644 drivers/net/qede/qede_rxtx.h > create mode 100644 drivers/net/qede/rte_pmd_qede_version.map > Checkpatch is reporting a lot of issues with this patch. Can you please look to reduce the number of hits in it. Perhaps you could use the "checkpatches.sh" script in the dpdk repo to check all patches in this set. Regards, /Bruce