From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org,
Paulo Zanoni <paulo.r.zanoni@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 3/4] drm/i915: opt-out CPU and WC mmaps from FBC
Date: Tue, 22 Mar 2016 12:15:09 +0100 [thread overview]
Message-ID: <20160322111509.GA28483@phenom.ffwll.local> (raw)
In-Reply-To: <87io0erem3.fsf@intel.com>
On Tue, Mar 22, 2016 at 12:28:20PM +0200, Jani Nikula wrote:
> On Mon, 21 Mar 2016, Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
> > +enum fb_mmap_wa_flags {
> > + FB_MMAP_WA_CPU = 1 << 0,
> > + FB_MMAP_WA_GTT = 1 << 1,
> > + FB_MMAP_WA_DISABLE = 1 << 2,
> > + FB_MMAP_WA_FLAG_COUNT = 3,
> > +};
>
> Drive-by review, adding bit flags as enums doesn't feel like what enums
> should be used for. I'd go for macros instead.
Pretty established convention, some like it since it allows gdb&friends to
decode your bitflags for you. So abusing enums as flag set is imo ok.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-22 11:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 19:26 [PATCH 0/4] Enable FBC on SKL Paulo Zanoni
2016-03-21 19:26 ` [PATCH 1/4] drm/i915/fbc: update busy_bits even for GTT and flip flushes Paulo Zanoni
2016-03-22 11:13 ` Daniel Vetter
2016-03-22 21:33 ` Zanoni, Paulo R
2016-03-21 19:26 ` [RFC xf86-video-intel] sna: Call dirtyfb for all non-tear-free cases Paulo Zanoni
2016-03-22 11:31 ` Daniel Vetter
2016-03-22 11:36 ` Chris Wilson
2016-03-22 21:35 ` Zanoni, Paulo R
2016-03-23 8:50 ` Daniel Vetter
2016-03-23 13:16 ` Zanoni, Paulo R
2016-03-21 19:26 ` [PATCH 2/4] drm/i915/fbc: sanitize i915.enable_fbc during FBC init Paulo Zanoni
2016-03-21 19:26 ` [PATCH 3/4] drm/i915: opt-out CPU and WC mmaps from FBC Paulo Zanoni
2016-03-22 2:19 ` kbuild test robot
2016-03-22 10:28 ` Jani Nikula
2016-03-22 11:15 ` Daniel Vetter [this message]
2016-03-22 13:52 ` Jani Nikula
2016-03-22 11:29 ` Daniel Vetter
2016-03-22 21:48 ` Zanoni, Paulo R
2016-03-23 8:53 ` Daniel Vetter
2016-03-23 16:04 ` Vivi, Rodrigo
2016-03-21 19:26 ` [PATCH 4/4] drm/i915/fbc: enable FBC on SKL too Paulo Zanoni
2016-03-22 11:16 ` Daniel Vetter
2016-03-22 21:51 ` Zanoni, Paulo R
2016-03-23 8:55 ` Daniel Vetter
2016-03-24 19:16 [PATCH 0/4] Enable FBC on SKL, v2 Paulo Zanoni
2016-03-24 19:16 ` [PATCH 3/4] drm/i915: opt-out CPU and WC mmaps from FBC Paulo Zanoni
2016-03-24 19:31 ` Chris Wilson
2016-03-24 20:53 ` Zanoni, Paulo R
2016-03-24 21:03 ` chris
2016-03-24 21:20 ` chris
2016-03-25 14:05 ` Zanoni, Paulo R
2016-03-25 14:17 ` chris
2016-03-29 11:55 ` Daniel Vetter
2016-03-29 12:24 ` chris
2016-03-24 21:21 ` Zanoni, Paulo R
2016-03-24 21:58 ` chris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160322111509.GA28483@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=paulo.r.zanoni@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.