From: Borislav Petkov <bp@alien8.de>
To: Sherry Hurwitz <sherry.hurwitz@amd.com>
Cc: Huang Rui <ray.huang@amd.com>,
Peter Zijlstra <peterz@infradead.org>,
tglx@linutronix.de, linux-kernel@vger.kernel.org,
mingo@kernel.org, aherrmann@suse.com, jencce.kernel@gmail.com,
Gang Long <gang.long@amd.com>
Subject: Re: [PATCH 2/3] x86/topology: Fix AMD core count
Date: Tue, 22 Mar 2016 12:22:18 +0100 [thread overview]
Message-ID: <20160322112218.GD3688@pd.tnic> (raw)
In-Reply-To: <56F0FDE7.8010802@amd.com>
Hi Sherry,
On Tue, Mar 22, 2016 at 03:10:15AM -0500, Sherry Hurwitz wrote:
> Boris, this documentation will help tremendously.
Yeah, I'm collecting more stuff for it. If you feel like something else
should be explained there, holler.
> In just this line of
> code:
>
> nr_local_cpus = nr_cores * nr_siblings
>
> we have an Intel HT = AMD core = logical_cpu
> and core = AMD compute unit.
>
> Anybody surprised there was a bug?
>
> The surprising thing is that running lscpu on a 32 core 2 socket 6300
> Opteron system without
> the patches I get the same output as with the patches and it matches Ray's.
> I don't see an impact.
Yeah, so the logic is closer to an Intel core which can have 1 or more
threads and we did set x86_max_cores to the number of Bulldozer cores
(each of them in a pair forming a Compute Unit). And that's fine but
then we did set smp_num_siblings to 2.
In any case, I'm not seeing any issues here too but we wanted for you
guys to run those changes too before we apply them.
In any case, they will be in 4.6 and you could test tip/master from time
to time and scream if there's an issue.
Thanks!
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2016-03-22 11:22 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 15:03 [PATCH 0/3] x86 topology fixes Peter Zijlstra
2016-03-18 15:03 ` [PATCH 1/3] x86/topology: Fix logical pkg mapping Peter Zijlstra
2016-03-19 9:30 ` [tip:x86/urgent] x86/topology: Fix logical package mapping tip-bot for Peter Zijlstra
2016-03-18 15:03 ` [PATCH 2/3] x86/topology: Fix AMD core count Peter Zijlstra
2016-03-18 16:41 ` Borislav Petkov
2016-03-21 3:07 ` Huang Rui
2016-03-21 3:46 ` Huang Rui
2016-03-21 8:26 ` Borislav Petkov
2016-03-21 9:18 ` Huang Rui
2016-03-21 8:56 ` Thomas Gleixner
2016-03-21 8:21 ` Peter Zijlstra
2016-03-21 9:46 ` Huang Rui
2016-03-21 13:57 ` Borislav Petkov
2016-03-22 8:10 ` Sherry Hurwitz
2016-03-22 11:22 ` Borislav Petkov [this message]
2016-03-21 8:23 ` Borislav Petkov
2016-03-21 10:05 ` Huang Rui
2016-03-21 10:23 ` Borislav Petkov
2016-03-19 9:24 ` Thomas Gleixner
2016-03-19 15:56 ` Borislav Petkov
2016-03-20 10:39 ` Peter Zijlstra
2016-03-20 11:04 ` Borislav Petkov
2016-03-20 12:32 ` Peter Zijlstra
2016-03-20 12:46 ` Peter Zijlstra
2016-03-20 13:09 ` Borislav Petkov
2016-03-20 17:08 ` Peter Zijlstra
2016-03-20 18:46 ` Borislav Petkov
2016-03-29 8:49 ` [tip:x86/urgent] perf/x86/amd: Cleanup Fam10h NB event constraints tip-bot for Peter Zijlstra
2016-03-22 7:56 ` [PATCH 2/3] x86/topology: Fix AMD core count Huang Rui
2016-03-18 15:03 ` [PATCH 3/3] x86/topology: Fix Intel HT disable Peter Zijlstra
2016-03-19 9:31 ` [tip:x86/urgent] " tip-bot for Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2016-03-16 6:48 4.5.0+ panic when setup loop device Xiong Zhou
2016-03-16 15:26 ` Thomas Gleixner
2016-03-17 1:56 ` Xiong Zhou
2016-03-17 9:52 ` Peter Zijlstra
2016-03-17 9:56 ` Peter Zijlstra
2016-03-17 10:21 ` Thomas Gleixner
2016-03-17 10:26 ` Peter Zijlstra
2016-03-17 11:39 ` Thomas Gleixner
2016-03-17 11:51 ` Peter Zijlstra
2016-03-17 11:57 ` Borislav Petkov
2016-03-17 12:01 ` Thomas Gleixner
2016-03-17 16:42 ` Jens Axboe
2016-03-17 18:26 ` Jens Axboe
2016-03-17 20:20 ` Thomas Gleixner
2016-03-17 20:23 ` Jens Axboe
2016-03-17 20:30 ` Thomas Gleixner
2016-03-17 20:41 ` Jens Axboe
2016-03-18 2:31 ` Xiong Zhou
2016-03-18 4:11 ` Mike Galbraith
2016-03-18 7:51 ` Peter Zijlstra
2016-03-18 10:15 ` Peter Zijlstra
2016-03-18 12:39 ` Mike Galbraith
2016-03-18 13:32 ` Peter Zijlstra
2016-03-18 14:07 ` Mike Galbraith
2016-03-18 11:55 ` Thomas Gleixner
2016-03-18 12:39 ` Mike Galbraith
2016-03-19 9:31 ` [tip:x86/urgent] x86/topology: Use total_cpus not nr_cpu_ids for logical packages tip-bot for Thomas Gleixner
2016-03-29 8:48 ` [tip:x86/urgent] x86/topology: Fix AMD core count tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160322112218.GD3688@pd.tnic \
--to=bp@alien8.de \
--cc=aherrmann@suse.com \
--cc=gang.long@amd.com \
--cc=jencce.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=ray.huang@amd.com \
--cc=sherry.hurwitz@amd.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.