From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: mediatek: fix checking for NULL instead of IS_ERR() in .probe Date: Wed, 23 Mar 2016 13:50:15 -0400 (EDT) Message-ID: <20160323.135015.4255305663652743.davem@davemloft.net> References: <1458687964-9690-1-git-send-email-vz@mleia.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: nbd@openwrt.org, blogic@openwrt.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org To: vz@mleia.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:59519 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755928AbcCWRuR (ORCPT ); Wed, 23 Mar 2016 13:50:17 -0400 In-Reply-To: <1458687964-9690-1-git-send-email-vz@mleia.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Vladimir Zapolskiy Date: Wed, 23 Mar 2016 01:06:04 +0200 > devm_ioremap_resource() returns ERR_PTR() value on error, it never > returns NULL, fix it and propagate the returned error upwards. > > Fixes: 656e705243fd ("net-next: mediatek: add support for MT7623 ethernet") > Signed-off-by: Vladimir Zapolskiy Applied, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: davem@davemloft.net (David Miller) Date: Wed, 23 Mar 2016 13:50:15 -0400 (EDT) Subject: [PATCH] net: mediatek: fix checking for NULL instead of IS_ERR() in .probe In-Reply-To: <1458687964-9690-1-git-send-email-vz@mleia.com> References: <1458687964-9690-1-git-send-email-vz@mleia.com> Message-ID: <20160323.135015.4255305663652743.davem@davemloft.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org From: Vladimir Zapolskiy Date: Wed, 23 Mar 2016 01:06:04 +0200 > devm_ioremap_resource() returns ERR_PTR() value on error, it never > returns NULL, fix it and propagate the returned error upwards. > > Fixes: 656e705243fd ("net-next: mediatek: add support for MT7623 ethernet") > Signed-off-by: Vladimir Zapolskiy Applied, thanks.