From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753820AbcCWGkI (ORCPT ); Wed, 23 Mar 2016 02:40:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60128 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752119AbcCWGkA (ORCPT ); Wed, 23 Mar 2016 02:40:00 -0400 Date: Wed, 23 Mar 2016 14:39:52 +0800 From: Peter Xu To: Steven Rostedt Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH trace-cmd 1/2] trace-cmd-listen: remove useless printf Message-ID: <20160323063952.GL28183@pxdev.xzpeter.org> References: <1458632442-6878-1-git-send-email-peterx@redhat.com> <1458632442-6878-2-git-send-email-peterx@redhat.com> <20160322091811.341b2e03@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160322091811.341b2e03@gandalf.local.home> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 22, 2016 at 09:18:11AM -0400, Steven Rostedt wrote: > > diff --git a/trace-listen.c b/trace-listen.c > > index 1e38eda..12cc9c5 100644 > > --- a/trace-listen.c > > +++ b/trace-listen.c > > @@ -721,7 +721,6 @@ static void do_accept_loop(int sfd) > > do { > > cfd = accept(sfd, (struct sockaddr *)&peer_addr, > > &peer_addr_len); > > - printf("connected!\n"); > > I probably kept this in for debugging. But I still think there should > be some kind of logging here. If anything, change this to a debug > print. I'm working on passing in --debug into the command line here, so > I'm not going to take this patch. It should be converted to the debug > coed. Sure. This is trivial. Please just drop it. -- peterx