All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@suse.de>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: mingo@kernel.org, hpa@zytor.com, tglx@linutronix.de,
	mcgrof@suse.com, jgross@suse.com, paul.gortmaker@windriver.com,
	konrad.wilk@oracle.com, elliott@hpe.com, x86@kernel.org,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface
Date: Wed, 23 Mar 2016 09:51:41 +0100	[thread overview]
Message-ID: <20160323085141.GC8031@pd.tnic> (raw)
In-Reply-To: <1458682845.6393.614.camel@hpe.com>

On Tue, Mar 22, 2016 at 03:40:45PM -0600, Toshi Kani wrote:
> Will change to "Prevent the OS from initializing the PAT MSR".
> 
> I wanted to clarify that "disable" does not mean to disable PAT MSR.

How do you "disable PAT MSR" ?

I think you're overdocumenting this. pat_disable() is as clear as day
what it does. It doesn't need any commenting...

> I've run checkpatch.pl and thought it was OK to have this warning (instead
> of a >80 warning) since the error message part was not split.  The
> "attempting" part is for debugging and its string is passed from the
> caller. 

We always put the quoted strings on a single line for easier grepping.
Forget the 80-cols rule.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
-- 

  reply	other threads:[~2016-03-23  8:51 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17  0:46 [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface Toshi Kani
2016-03-17  0:46 ` Toshi Kani
2016-03-17  0:46 ` [PATCH v2 3/6] x86/mtrr: Fix Xorg crashes in Qemu sessions Toshi Kani
2016-03-22 17:00   ` Borislav Petkov
2016-03-22 17:00   ` Borislav Petkov
2016-03-22 21:53     ` Toshi Kani
2016-03-23  8:44       ` Borislav Petkov
2016-03-23  8:44       ` Borislav Petkov
2016-03-23 15:53         ` Toshi Kani
2016-03-23 15:53         ` Toshi Kani
2016-03-23 21:47           ` Toshi Kani
2016-03-23 21:47           ` Toshi Kani
2016-03-22 21:53     ` Toshi Kani
2016-03-17  0:46 ` Toshi Kani
2016-03-17  0:46 ` [PATCH v2 4/6] x86/mtrr: Fix PAT init handling when MTRR MSR is disabled Toshi Kani
2016-03-17  0:46 ` Toshi Kani
2016-03-22 17:01   ` Borislav Petkov
2016-03-22 22:02     ` Toshi Kani
2016-03-22 22:02     ` Toshi Kani
2016-03-22 17:01   ` Borislav Petkov
2016-03-17  0:46 ` [PATCH v2 5/6] x86/xen,pat: Remove PAT table init code from Xen Toshi Kani
2016-03-22 17:02   ` [PATCH v2 5/6] x86/xen, pat: " Borislav Petkov
2016-03-22 17:02   ` [PATCH v2 5/6] x86/xen,pat: " Borislav Petkov
2016-03-23  6:08     ` [PATCH v2 5/6] x86/xen, pat: " Juergen Gross
2016-03-23  6:08     ` [PATCH v2 5/6] x86/xen,pat: " Juergen Gross
2016-03-17  0:46 ` [PATCH v2 5/6] x86/xen, pat: " Toshi Kani
2016-03-17  0:46 ` [PATCH v2 6/6] x86/pat: Document PAT initializations Toshi Kani
2016-03-22 17:02   ` Borislav Petkov
2016-03-22 17:02   ` Borislav Petkov
2016-03-22 22:15     ` Toshi Kani
2016-03-22 22:15     ` Toshi Kani
2016-03-17  0:46 ` Toshi Kani
2016-03-22 16:59 ` [PATCH v2 2/6] x86/mm/pat: Add pat_disable() interface Borislav Petkov
2016-03-22 16:59 ` Borislav Petkov
2016-03-22 21:40   ` Toshi Kani
2016-03-23  8:51     ` Borislav Petkov [this message]
2016-03-23 15:49       ` Toshi Kani
2016-03-23 15:49       ` Toshi Kani
2016-03-23  8:51     ` Borislav Petkov
2016-03-22 21:40   ` Toshi Kani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160323085141.GC8031@pd.tnic \
    --to=bp@suse.de \
    --cc=elliott@hpe.com \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@suse.com \
    --cc=mingo@kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=tglx@linutronix.de \
    --cc=toshi.kani@hpe.com \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.