From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754276AbcCWKXz (ORCPT ); Wed, 23 Mar 2016 06:23:55 -0400 Received: from foss.arm.com ([217.140.101.70]:45368 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751528AbcCWKXq (ORCPT ); Wed, 23 Mar 2016 06:23:46 -0400 Date: Wed, 23 Mar 2016 10:26:14 +0000 From: Lorenzo Pieralisi To: Jisheng Zhang Cc: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: firmware: psci: make two helper functions static Message-ID: <20160323102614.GA8311@red-moon> References: <1458657105-2348-1-git-send-email-jszhang@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458657105-2348-1-git-send-email-jszhang@marvell.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 22, 2016 at 10:31:45PM +0800, Jisheng Zhang wrote: > psci_power_state_loses_context() and psci_power_state_is_valid are only > used internally now, so make them static. > > Signed-off-by: Jisheng Zhang > --- > drivers/firmware/psci.c | 4 ++-- > include/linux/psci.h | 2 -- > 2 files changed, 2 insertions(+), 4 deletions(-) Thanks, I will apply it and send it for next cycle. Lorenzo > diff --git a/drivers/firmware/psci.c b/drivers/firmware/psci.c > index 11bfee8..6d86881 100644 > --- a/drivers/firmware/psci.c > +++ b/drivers/firmware/psci.c > @@ -91,7 +91,7 @@ static inline bool psci_has_ext_power_state(void) > PSCI_1_0_FEATURES_CPU_SUSPEND_PF_MASK; > } > > -bool psci_power_state_loses_context(u32 state) > +static bool psci_power_state_loses_context(u32 state) > { > const u32 mask = psci_has_ext_power_state() ? > PSCI_1_0_EXT_POWER_STATE_TYPE_MASK : > @@ -100,7 +100,7 @@ bool psci_power_state_loses_context(u32 state) > return state & mask; > } > > -bool psci_power_state_is_valid(u32 state) > +static bool psci_power_state_is_valid(u32 state) > { > const u32 valid_mask = psci_has_ext_power_state() ? > PSCI_1_0_EXT_POWER_STATE_MASK : > diff --git a/include/linux/psci.h b/include/linux/psci.h > index 393efe2..bdea1cb 100644 > --- a/include/linux/psci.h > +++ b/include/linux/psci.h > @@ -21,8 +21,6 @@ > #define PSCI_POWER_STATE_TYPE_POWER_DOWN 1 > > bool psci_tos_resident_on(int cpu); > -bool psci_power_state_loses_context(u32 state); > -bool psci_power_state_is_valid(u32 state); > > int psci_cpu_init_idle(unsigned int cpu); > int psci_cpu_suspend_enter(unsigned long index); > -- > 2.8.0.rc3 >