From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zhe Tao <zhe.tao@intel.com>
Subject: Re: [PATCH 1/2 v5] i40e: support floating VEB config
Date: Thu, 24 Mar 2016 10:31:37 +0800
Message-ID: <20160324023137.GA43827@intel.com>
References: <1456906110-15081-1-git-send-email-zhe.tao@intel.com>
 <1458736030-1283-1-git-send-email-zhe.tao@intel.com>
 <1458736030-1283-2-git-send-email-zhe.tao@intel.com>
 <25151917.GNeR10epP5@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, jingjing.wu@intel.com
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 715212BE2
 for <dev@dpdk.org>; Thu, 24 Mar 2016 11:46:22 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <25151917.GNeR10epP5@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Mar 23, 2016 at 01:51:09PM +0100, Thomas Monjalon wrote:
> 2016-03-23 20:27, Zhe Tao:
> > Add the new floating related argument option in the EAL.
> > Using this parameter, all the samples can decide whether to use legacy VEB/VEPA
> > or floating VEB.
> > Even the floating argument is provided in the EAL, but this floating
> > feature are only support for FVL so far.
> > 
> > Signed-off-by: Zhe Tao <zhe.tao@intel.com>
> > ---
> >  doc/guides/testpmd_app_ug/run_app.rst      | 4 ++++
> >  lib/librte_eal/common/eal_common_options.c | 4 ++++
> >  lib/librte_eal/common/eal_internal_cfg.h   | 1 +
> >  lib/librte_eal/common/eal_options.h        | 2 ++
> >  4 files changed, 11 insertions(+)
> 
> The label of this patch is "i40e" but it doesn't touch i40e.
> Actually it is an EAL change but there should not be related to EAL.
> It seems to be a config option of the device.
> Please check how ftag has been enabled in fm10k:
> 	dpdk.org/browse/dpdk/commit/?id=7958b1310d5e
very good suggestion, thanks for the advice