From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753270AbcC0GGX (ORCPT ); Sun, 27 Mar 2016 02:06:23 -0400 Received: from ozlabs.org ([103.22.144.67]:38304 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752080AbcC0GGW (ORCPT ); Sun, 27 Mar 2016 02:06:22 -0400 Date: Sun, 27 Mar 2016 17:06:18 +1100 From: Stephen Rothwell To: Linus Torvalds , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Peter Zijlstra Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo Subject: linux-next: build failure in Linus' tree Message-ID: <20160327170618.7713e43c@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, After merging the fixes tree, today's linux-next build (perf powerpcle) failed like this: arch/powerpc/util/header.c:17:1: error: no previous prototype for 'get_cpuid' [-Werror=missing-prototypes] get_cpuid(char *buffer, size_t sz) ^ arch/powerpc/util/header.c: In function 'get_cpuid': arch/powerpc/util/header.c:24:7: error: implicit declaration of function 'scnprintf' [-Werror=implicit-function-declaration] nb = scnprintf(buffer, sz, "%lu,%lu$", PVR_VER(pvr), PVR_REV(pvr)); ^ arch/powerpc/util/header.c:24:2: error: nested extern declaration of 'scnprintf' [-Werror=nested-externs] nb = scnprintf(buffer, sz, "%lu,%lu$", PVR_VER(pvr), PVR_REV(pvr)); ^ Caused by commit 531d2410635c ("perf tools: Do not include stringify.h from the kernel sources") I added the following fix patch for for today: From: Stephen Rothwell Date: Sun, 27 Mar 2016 14:44:26 +1100 Subject: [PATCH] perf tools: we stil need header.h for various things Fixes: 531d2410635c ("perf tools: Do not include stringify.h from the kernel sources") Signed-off-by: Stephen Rothwell --- tools/perf/arch/powerpc/util/header.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/arch/powerpc/util/header.c b/tools/perf/arch/powerpc/util/header.c index 6138bdef6e63..8a0191a11f87 100644 --- a/tools/perf/arch/powerpc/util/header.c +++ b/tools/perf/arch/powerpc/util/header.c @@ -5,6 +5,8 @@ #include #include +#include "../../util/header.h" + #define mfspr(rn) ({unsigned long rval; \ asm volatile("mfspr %0," __stringify(rn) \ : "=r" (rval)); rval; }) -- 2.7.0 -- Cheers, Stephen Rothwell