From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:40296 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932705AbcC3I2h (ORCPT ); Wed, 30 Mar 2016 04:28:37 -0400 Date: Wed, 30 Mar 2016 10:29:08 +0200 From: Jan Kara To: Theodore Ts'o Cc: jack@suse.cz, Linux Filesystem Development List Subject: Re: [PATCH 0/5] Misc. cleanup and portability patches for quota-tools Message-ID: <20160330082908.GE12776@quack.suse.cz> References: <1459298887-21519-1-git-send-email-tytso@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459298887-21519-1-git-send-email-tytso@mit.edu> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Ted, On Tue 29-03-16 20:48:02, Ted Tso wrote: > Here are some patches that provide some additional compatibility for > quota-tools package. > > No, this isn't quite enough to allow quota-tools to build for > Android/Bionic. These changes are sufficient to allow things to > build, but there are still a few missing functions, most notably a > syscall wrapper for quotactl(2), that are missing and which I'll add > to a compatibility library in xfstests-bld, and/or get upstream into > the Bionic libc at some point, if I can. > > I think these changes are generally useful, though. For example, with > glibc on x86, if you try to do a build after configuring with > --enable-rpc=no, the result is a huge number of build failures. This > patch series will fix things so we can compile without rpc support. Thanks for the fixes! I have merged them all. I had to slightly fix nl_langinfo() checking so that HAVE_NL_LANGINFO is really defined in case we have nl_langinfo() but it was easy enough. I have also added explicit includes of stdlib.h into some files as otherwise compilation without RPC emitted some warnings. Honza -- Jan Kara SUSE Labs, CR