From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Stephane Eranian <eranian@google.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Clark Williams <williams@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andy Lutomirski <luto@kernel.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Zi Shen Lim <zlim.lnx@gmail.com>
Subject: Re: [PATCH 10/11] perf tools: Add probing for udev86 library
Date: Wed, 30 Mar 2016 11:10:53 -0300 [thread overview]
Message-ID: <20160330141053.GB3420@kernel.org> (raw)
In-Reply-To: <20160330135246.GA29990@gmail.com>
Em Wed, Mar 30, 2016 at 03:52:46PM +0200, Ingo Molnar escreveu:
> * Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
> > Em Wed, Mar 30, 2016 at 12:43:27PM +0200, Ingo Molnar escreveu:
> > > > From: Andi Kleen <ak@linux.intel.com>
> > > > Add autoprobing for the udev86 disassembler library.
> > > So the typo in the title is confusing, what is 'udev86'?
> > > Also, this library does not seem to be available on stock Ubuntu. We should not be
> > > adding library dependencies that cannot be resolved on major distros:
> > Ok, I'll remove, I thought it would be ok because I fired up:
> > # dnf install udis86-devel
> > On fedora and it installed straight away, but after I started trying to
> > update my docker images I couldn't find it on debian
> > experimental/unstable:
> > Nor even in OpenSuSE:
> > Or even Mageia:
> Yeah, so udis86 also seems to be a pretty old, relatively stale library with no
> support for new instructions AFAICS.
> So I'd rather encourage librarizing one of the x86 instruction decoders in
> arch/x86/, and adding pretty-printing functionality to it. The code can already
That was my first reaction too, but then, having some interesting
results right now, I thought, would either push development on the
udis86 code or show that it is not going anywhere and thus we better try
doing what you're suggesting, which was my initial suggestion to Andi.
> see instruction boundaries, which is the hardest part.
> That would also be better supported on non-x86 architectures in the long run:
> triton:~/tip> find arch/ -name insn.c | xargs ls -l
> -rw-rw-r-- 1 mingo mingo 30244 Mar 29 11:24 arch/arm64/kernel/insn.c
> -rw-rw-r-- 1 mingo mingo 1347 Dec 8 06:27 arch/arm/kernel/insn.c
> -rw-rw-r-- 1 mingo mingo 15123 Mar 30 12:31 arch/x86/lib/insn.c
> Such an in-kernel-repo library could also be used by live kernel debuggers such as
> kgdb/kdb, oops/crash-time disassembly printout, etc.
> ... so how about that direction instead?
I'd much rather see it in that direction too, for the time being, I'm
removing the udis86 patches from acme/perf/core,
- Arnaldo
next prev parent reply other threads:[~2016-03-30 14:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 23:41 [GIT PULL 00/11] perf/core improvements and fixes Arnaldo Carvalho de Melo
2016-03-29 23:41 ` [PATCH 01/11] perf mem: Add -U/-K (--all-user/--all-kernel) options Arnaldo Carvalho de Melo
2016-03-29 23:41 ` [PATCH 02/11] perf tools: Make hists__collapse_insert_entry static Arnaldo Carvalho de Melo
2016-03-29 23:41 ` [PATCH 03/11] perf tools: Make -f/--force option documentation consistent across tools Arnaldo Carvalho de Melo
2016-03-29 23:41 ` [PATCH 04/11] perf tests: Add test to check for event times Arnaldo Carvalho de Melo
2016-03-29 23:41 ` [PATCH 05/11] perf config: Remove duplicated set_buildid_dir calls Arnaldo Carvalho de Melo
2016-03-29 23:41 ` [PATCH 06/11] perf config: Rework buildid_dir_command_config to perf_buildid_config Arnaldo Carvalho de Melo
2016-03-29 23:41 ` [PATCH 07/11] perf config: Rename 'v' to 'home' in set_buildid_dir() Arnaldo Carvalho de Melo
2016-03-29 23:41 ` [PATCH 08/11] perf script perl: Perl scripts now get a backtrace, like the python ones Arnaldo Carvalho de Melo
2016-03-29 23:41 ` [PATCH 09/11] perf tools: Add support for skipping itrace instructions Arnaldo Carvalho de Melo
2016-03-29 23:41 ` [PATCH 10/11] perf tools: Add probing for udev86 library Arnaldo Carvalho de Melo
2016-03-30 10:43 ` Ingo Molnar
2016-03-30 13:36 ` Arnaldo Carvalho de Melo
2016-03-30 13:52 ` Ingo Molnar
2016-03-30 14:10 ` Arnaldo Carvalho de Melo [this message]
2016-03-30 14:47 ` Arnaldo Carvalho de Melo
2016-03-31 6:34 ` Ingo Molnar
2016-03-30 15:08 ` Andi Kleen
2016-03-31 6:49 ` Ingo Molnar
2016-03-30 14:42 ` Andi Kleen
2016-03-29 23:41 ` [PATCH 11/11] perf script: Add support for printing assembler Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330141053.GB3420@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=dvlasenk@redhat.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
--cc=zlim.lnx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.