From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alGFw-0001Cb-NU for qemu-devel@nongnu.org; Wed, 30 Mar 2016 09:33:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alGFt-0004rL-IV for qemu-devel@nongnu.org; Wed, 30 Mar 2016 09:33:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alGFt-0004qf-DF for qemu-devel@nongnu.org; Wed, 30 Mar 2016 09:33:53 -0400 Date: Wed, 30 Mar 2016 15:33:47 +0200 From: Igor Mammedov Message-ID: <20160330153347.302b7d0b@igors-macbook-pro.local> In-Reply-To: <1458570071-1935-1-git-send-email-stefanb@us.ibm.com> References: <1458570071-1935-1-git-send-email-stefanb@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] acpi: Fix TPM ACPI description to make TPM usable on Windows List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Berger Cc: crobinso@redhat.com, Stefan Berger , qemu-devel@nongnu.org, mst@redhat.com On Mon, 21 Mar 2016 10:21:11 -0400 Stefan Berger wrote: > This patch addresses BZ 1281413. > > Fix the APCI description to make it work on Windows again. The ACPI > description was broken in commit 9e47226. above commit just added missing ASL description for TMP device and you also posted exactly similar patch back then. Current commit message is pretty useless, Pls describe in commit message what/how is broken and how/why patch fixes it. > > Signed-off-by: Stefan Berger > --- > hw/i386/acpi-build.c | 26 ++++++++++++-------------- > 1 file changed, 12 insertions(+), 14 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 325d8ce..c6e90b6 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -2334,22 +2334,20 @@ build_dsdt(GArray *table_data, GArray *linker, > Aml *scope = aml_scope("PCI0"); > /* Scan all PCI buses. Generate tables to support > hotplug. */ build_append_pci_bus_devices(scope, bus, > pm->pcihp_bridge_en); - > - if (misc->tpm_version != TPM_VERSION_UNSPEC) { > - dev = aml_device("ISA.TPM"); > - aml_append(dev, aml_name_decl("_HID", > aml_eisaid("PNP0C31"))); > - aml_append(dev, aml_name_decl("_STA", > aml_int(0xF))); > - crs = aml_resource_template(); > - aml_append(crs, > aml_memory32_fixed(TPM_TIS_ADDR_BASE, > - TPM_TIS_ADDR_SIZE, AML_READ_WRITE)); > - aml_append(crs, aml_irq_no_flags(TPM_TIS_IRQ)); > - aml_append(dev, aml_name_decl("_CRS", crs)); > - aml_append(scope, dev); > - } > - > - aml_append(sb_scope, scope); it's ISA device so it should stay in ISA scope, I'll post and alternative fix for TPM_TIS_ADDR_BASE as follow up to this series. > } > } > + > + if (misc->tpm_version != TPM_VERSION_UNSPEC) { > + dev = aml_device("TPM"); > + aml_append(dev, aml_name_decl("_HID", > aml_eisaid("PNP0C31"))); > + aml_append(dev, aml_name_decl("_STA", aml_int(0xF))); > + crs = aml_resource_template(); > + aml_append(crs, aml_memory32_fixed(TPM_TIS_ADDR_BASE, > + TPM_TIS_ADDR_SIZE, AML_READ_WRITE)); > + //aml_append(crs, aml_irq_no_flags(TPM_TIS_IRQ)); silent change, why IRQ descriptor is commented out, it seems the device uses/initializes it? I'd split IRQ change in a separate patch that explains why it shouldn't be in TPM._CRS. > + aml_append(dev, aml_name_decl("_CRS", crs)); > + aml_append(sb_scope, dev); > + } > aml_append(dsdt, sb_scope); > } >