From: Tejun Heo <tj@kernel.org>
To: Damien Le Moal <Damien.LeMoal@hgst.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] libata-core: Allow longer timeout for drive spinup from PUIS
Date: Wed, 30 Mar 2016 14:38:46 -0400 [thread overview]
Message-ID: <20160330183846.GK7822@mtj.duckdns.org> (raw)
In-Reply-To: <539D1F09-E6EB-47F1-A66E-C182CA675359@hgst.com>
Hello, Damien.
On Tue, Mar 22, 2016 at 08:22:22AM +0000, Damien Le Moal wrote:
> diff --git a/include/linux/ata.h b/include/linux/ata.h
> index c1a2f34..f460e7f 100644
> --- a/include/linux/ata.h
> +++ b/include/linux/ata.h
> @@ -371,7 +371,8 @@ enum {
> SETFEATURES_AAM_ON = 0x42,
> SETFEATURES_AAM_OFF = 0xC2,
>
> - SETFEATURES_SPINUP = 0x07, /* Spin-up drive */
> + SETFEATURES_SPINUP = 0x07, /* Spin-up drive */
> + SETFEATURES_SPINUP_TIMEOUT = 30, /* 30s timeout for drive spin-up from PUIS */
Other timeout constants are defined in msecs. Let's do the same here.
Also, can you please send the email as plain-text without the base64
encoding? If you can't, please send the patch as an attachment
instead.
Thanks.
--
tejun
next prev parent reply other threads:[~2016-03-30 18:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 8:22 [PATCH] libata-core: Allow longer timeout for drive spinup from PUIS Damien Le Moal
2016-03-30 18:38 ` Tejun Heo [this message]
2016-04-02 12:23 ` Damien Le Moal
2016-04-04 16:18 ` Tejun Heo
2016-04-07 1:22 ` Damien Le Moal
2016-04-07 11:00 ` James Bottomley
2016-04-07 17:46 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330183846.GK7822@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=Damien.LeMoal@hgst.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.