All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Gabriel Feceoru <gabriel.feceoru@intel.com>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>,
	daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org
Subject: Re: [REGRESSION] system hang on ILK/SNB/IVB
Date: Wed, 30 Mar 2016 23:35:08 +0200	[thread overview]
Message-ID: <20160330213508.GA10407@wunner.de> (raw)
In-Reply-To: <56FC0ADA.6030802@intel.com>

Hi Gabriel,

On Wed, Mar 30, 2016 at 08:20:26PM +0300, Gabriel Feceoru wrote:
> This commit causes a hang while running kms suspend tests
> (kms_pipe_crc_basic@suspend-read-crc-pipe-*) on ILK/SNB/IVB, affecting CI.

This happened with v1 but not with v2 of the patch.
Please check if somehow v1 ended up in your tree.

v2 passed CI fine, save for one warning not caused by the patch:
https://patchwork.freedesktop.org/series/4068/

For comparison, this was v1:
https://patchwork.freedesktop.org/patch/75840/

Best regards,

Lukas

> 
> Probably the same problem with the one in v2, but on older HW.
> 
> 
> commit a7442b93cf32c1e1ddb721a26cd1f92302e2a222
> Author: Lukas Wunner <lukas@wunner.de>
> Date:   Wed Mar 9 12:52:53 2016 +0100
> 
>     drm/i915: Fix races on fbdev
> 
>     The ->lastclose callback invokes intel_fbdev_restore_mode() and has
>     been witnessed to run before intel_fbdev_initial_config_async()
>     has finished.
> 
>     We might likewise receive hotplug events before we've had a chance to
>     fully set up the fbdev.
> 
>     Fix by waiting for the asynchronous thread to finish.
> 
>     v2:
>     An async_synchronize_full() was also added to intel_fbdev_set_suspend()
>     in v1 which turned out to be entirely gratuitous. It caused a deadlock
>     on suspend (discovered by CI, thanks to Damien Lespiau and Tomi Sarvela
>     for CI support) and was unnecessary since a device is never suspended
>     until its ->probe callback (and all asynchronous tasks it scheduled)
>     have finished. See dpm_prepare(), which calls wait_for_device_probe(),
>     which calls async_synchronize_full().
> 
>     Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93580
>     Reported-by: Gustav Fägerlind <gustav.fagerlind@gmail.com>
>     Reported-by: "Li, Weinan Z" <weinan.z.li@intel.com>
>     Cc: Chris Wilson <chris@chris-wilson.co.uk>
>     Cc: stable@vger.kernel.org
>     Signed-off-by: Lukas Wunner <lukas@wunner.de>
>     Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>     Link: http://patchwork.freedesktop.org/patch/msgid/20160309115147.67B2B6E0D3@gabe.freedesktop.org
> 
> 
> Regards,
> Gabriel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-03-30 21:33 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30 17:20 [REGRESSION] system hang on ILK/SNB/IVB Gabriel Feceoru
2016-03-30 17:57 ` [PATCH] drm/i915: Protect fbdev across slow or failed initialisation Chris Wilson
2016-03-30 18:10   ` kbuild test robot
2016-03-30 18:10   ` kbuild test robot
2016-03-30 18:26   ` kbuild test robot
2016-03-30 18:30   ` Chris Wilson
2016-03-30 18:56   ` [PATCH v3] " Chris Wilson
2016-03-31 12:00     ` Gabriel Feceoru
2016-03-31 13:57       ` [PATCH v4 1/2] " Chris Wilson
2016-03-31 13:57         ` [PATCH v4 2/2] drm/i915: Move fbdev_suspend_work to intel_fbdev Chris Wilson
2016-03-31 15:22           ` Joonas Lahtinen
2016-03-31 15:30             ` Chris Wilson
2016-03-31 15:56               ` Joonas Lahtinen
2016-03-31 16:05         ` [PATCH v4 1/2] drm/i915: Protect fbdev across slow or failed initialisation Joonas Lahtinen
2016-03-31 16:13           ` Chris Wilson
2016-03-31 16:28             ` Joonas Lahtinen
2016-03-31 16:30             ` Lukas Wunner
2016-03-30 18:47 ` [REGRESSION] system hang on ILK/SNB/IVB Daniel Vetter
2016-03-30 21:35 ` Lukas Wunner [this message]
2016-03-31  7:21   ` Tomi Sarvela
2016-03-31 20:35     ` Lukas Wunner
2016-04-01  7:59       ` Tomi Sarvela
2016-03-31  7:42   ` Gabriel Feceoru
2016-03-31 15:23     ` Lukas Wunner
2016-03-31 14:42 ` ✗ Fi.CI.BAT: failure for drm/i915: Protect fbdev across slow or failed initialisation (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160330213508.GA10407@wunner.de \
    --to=lukas@wunner.de \
    --cc=daniel.vetter@ffwll.ch \
    --cc=gabriel.feceoru@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tomi.p.sarvela@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.