All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: akinobu.mita@gmail.com
Cc: netdev@vger.kernel.org, msink@permonline.ru
Subject: Re: [PATCH 3/4] net: w5100: enable to support sleepable register access interface
Date: Thu, 31 Mar 2016 15:30:40 -0400 (EDT)	[thread overview]
Message-ID: <20160331.153040.1786802199114216613.davem@davemloft.net> (raw)
In-Reply-To: <1459355920-14623-3-git-send-email-akinobu.mita@gmail.com>

From: Akinobu Mita <akinobu.mita@gmail.com>
Date: Thu, 31 Mar 2016 01:38:39 +0900

> +	struct sk_buff_head tx_queue;

The way the queueing works in this driver is that it is only possible
to have one SKB being transmitted at one time.

This is evident by how the driver immediately stops the TX queue when
it is given a new packet to transmit, and this is woken up by the TX
completion IRQ.

So don't use a queue here, just use a plain single pointer.

The SKB queue you're using here is going to also do locking which is
even more unnecessary overhead.

Thanks.

  reply	other threads:[~2016-03-31 19:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30 16:38 [PATCH 1/4] net: w5100: move mmiowb into register access callbacks Akinobu Mita
2016-03-30 16:38 ` [PATCH 2/4] net: w5100: add ability to support other bus interface Akinobu Mita
2016-03-30 16:38 ` [PATCH 3/4] net: w5100: enable to support sleepable register access interface Akinobu Mita
2016-03-31 19:30   ` David Miller [this message]
2016-04-01 16:42     ` Akinobu Mita
2016-03-30 16:38 ` [PATCH 4/4] net: w5100: support SPI interface mode Akinobu Mita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160331.153040.1786802199114216613.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akinobu.mita@gmail.com \
    --cc=msink@permonline.ru \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.