From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] Remove kretprobe_trampoline_holder.
Date: Thu, 31 Mar 2016 13:53:11 +0530 [thread overview]
Message-ID: <20160331082311.GA17907@naverao1-tp.ibm.com> (raw)
In-Reply-To: <1459195592-6559-1-git-send-email-bauerman@linux.vnet.ibm.com>
On 2016/03/28 05:06PM, Thiago Jung Bauermann wrote:
> Fixes the following testsuite failure:
>
> $ sudo ./perf test -v kallsyms
> 1: vmlinux symtab matches kallsyms :
> --- start ---
> test child forked, pid 12489
> Using /proc/kcore for kernel object code
> Looking at the vmlinux_path (8 entries long)
> Using /boot/vmlinux for symbols
> 0xc00000000003d300: diff name v: .kretprobe_trampoline_holder k: kretprobe_trampoline
> Maps only in vmlinux:
> c00000000086ca38-c000000000879b6c 87ca38 [kernel].text.unlikely
> c000000000879b6c-c000000000bf0000 889b6c [kernel].meminit.text
> c000000000bf0000-c000000000c53264 c00000 [kernel].init.text
> c000000000c53264-d000000004250000 c63264 [kernel].exit.text
> d000000004250000-d000000004450000 0 [libcrc32c]
> d000000004450000-d000000004620000 0 [xfs]
> d000000004620000-d000000004680000 0 [autofs4]
> d000000004680000-d0000000046e0000 0 [x_tables]
> d0000000046e0000-d000000004780000 0 [ip_tables]
> d000000004780000-d0000000047e0000 0 [rng_core]
> d0000000047e0000-ffffffffffffffff 0 [pseries_rng]
> Maps in vmlinux with a different name in kallsyms:
> Maps only in kallsyms:
> d000000000000000-f000000000000000 1000000000010000 [kernel.kallsyms]
> f000000000000000-ffffffffffffffff 3000000000010000 [kernel.kallsyms]
> test child finished with -1
> ---- end ----
> vmlinux symtab matches kallsyms: FAILED!
You should indent the above output -- in this specific case, the start
marker interferes with git am.
Apart from that, I have tested this patch and kretprobe works fine. A
minor nit I had is that we end up with a non-dot function in .text
without a corresponding function descriptor for kretprobe_trampoline.
But, since this is a trampoline, I think that is good. So, for this
patch:
Reviewed-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
- Naveen
next prev parent reply other threads:[~2016-03-31 8:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 17:17 [PATCH] Make kretprobe_trampoline symbol look like a function Thiago Jung Bauermann
2016-03-25 8:24 ` Michael Ellerman
2016-03-28 20:06 ` [PATCH] Remove kretprobe_trampoline_holder Thiago Jung Bauermann
2016-03-28 20:29 ` Thiago Jung Bauermann
2016-03-28 23:45 ` Michael Ellerman
2016-03-29 18:34 ` Thiago Jung Bauermann
2016-03-30 0:09 ` Michael Ellerman
2016-03-29 3:31 ` Michael Ellerman
2016-03-29 23:35 ` Thiago Jung Bauermann
2016-03-30 8:04 ` Naveen N. Rao
2016-03-30 8:46 ` Naveen N. Rao
2016-03-30 9:09 ` Michael Ellerman
2016-03-30 18:38 ` Thiago Jung Bauermann
2016-03-31 8:23 ` Naveen N. Rao [this message]
2016-03-31 20:16 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331082311.GA17907@naverao1-tp.ibm.com \
--to=naveen.n.rao@linux.vnet.ibm.com \
--cc=bauerman@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.