From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Date: Thu, 31 Mar 2016 10:58:53 +0000 Subject: Re: [PATCH 0/11] introduce down_write_killable for rw_semaphore Message-Id: <20160331105853.GE27831@dhcp22.suse.cz> List-Id: References: <1456750705-7141-1-git-send-email-mhocko@kernel.org> <20160330133217.GV3408@twins.programming.kicks-ass.net> <20160331085926.GB27831@dhcp22.suse.cz> <20160331092005.GA18640@gmail.com> In-Reply-To: <20160331092005.GA18640@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ingo Molnar Cc: Peter Zijlstra , Andrew Morton , LKML , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , "David S. Miller" , Tony Luck , Chris Zankel , Max Filippov , x86@kernel.org, linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org On Thu 31-03-16 11:20:05, Ingo Molnar wrote: > > * Michal Hocko wrote: > > > On Wed 30-03-16 15:32:17, Peter Zijlstra wrote: > > > On Mon, Feb 29, 2016 at 01:58:14PM +0100, Michal Hocko wrote: > > > > I have tested on x86 with OOM situations with high mmap_sem contention > > > > (basically many parallel page faults racing with many parallel mmap/munmap > > > > tight loops) so the waiters for the write locks are routinely interrupted > > > > by SIGKILL. > > > > > > Aside from the one niggle (as per the other email) they look good to me > > > and I would take them through the tip/locking tree. > > > > Thanks for the review! I understand that tip/locking would be the most > > appropriate place [...] > > Yes. > > > [...] but I am wondering whether this causes some issues with the follow up > > patches which use this new API and which I expect to go via Andrew's tree. > > So AFAIK Andrew's tree is based on top of linux-next, so once it goes into > tip:locking/core, -mm can pick it up as well 1-2 days later. OK. Andrew, just make sure you send the follow up changes to Linus after tip/locking is merged. > Please send the changes in isolation, for merge into the locking tree. Yes, that's what I plan to do in few days. Thanks! -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756130AbcCaK7A (ORCPT ); Thu, 31 Mar 2016 06:59:00 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34871 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753272AbcCaK64 (ORCPT ); Thu, 31 Mar 2016 06:58:56 -0400 Date: Thu, 31 Mar 2016 12:58:53 +0200 From: Michal Hocko To: Ingo Molnar Cc: Peter Zijlstra , Andrew Morton , LKML , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , "David S. Miller" , Tony Luck , Chris Zankel , Max Filippov , x86@kernel.org, linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 0/11] introduce down_write_killable for rw_semaphore Message-ID: <20160331105853.GE27831@dhcp22.suse.cz> References: <1456750705-7141-1-git-send-email-mhocko@kernel.org> <20160330133217.GV3408@twins.programming.kicks-ass.net> <20160331085926.GB27831@dhcp22.suse.cz> <20160331092005.GA18640@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160331092005.GA18640@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 31-03-16 11:20:05, Ingo Molnar wrote: > > * Michal Hocko wrote: > > > On Wed 30-03-16 15:32:17, Peter Zijlstra wrote: > > > On Mon, Feb 29, 2016 at 01:58:14PM +0100, Michal Hocko wrote: > > > > I have tested on x86 with OOM situations with high mmap_sem contention > > > > (basically many parallel page faults racing with many parallel mmap/munmap > > > > tight loops) so the waiters for the write locks are routinely interrupted > > > > by SIGKILL. > > > > > > Aside from the one niggle (as per the other email) they look good to me > > > and I would take them through the tip/locking tree. > > > > Thanks for the review! I understand that tip/locking would be the most > > appropriate place [...] > > Yes. > > > [...] but I am wondering whether this causes some issues with the follow up > > patches which use this new API and which I expect to go via Andrew's tree. > > So AFAIK Andrew's tree is based on top of linux-next, so once it goes into > tip:locking/core, -mm can pick it up as well 1-2 days later. OK. Andrew, just make sure you send the follow up changes to Linus after tip/locking is merged. > Please send the changes in isolation, for merge into the locking tree. Yes, that's what I plan to do in few days. Thanks! -- Michal Hocko SUSE Labs