From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753942AbcDATSZ (ORCPT ); Fri, 1 Apr 2016 15:18:25 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:52683 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751045AbcDATSY (ORCPT ); Fri, 1 Apr 2016 15:18:24 -0400 Date: Fri, 01 Apr 2016 15:18:20 -0400 (EDT) Message-Id: <20160401.151820.127036849232206611.davem@davemloft.net> To: mw@semihalf.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux@arm.linux.org.uk, sebastian.hesselbarth@gmail.com, andrew@lunn.ch, jason@lakedaemon.net, thomas.petazzoni@free-electrons.com, gregory.clement@free-electrons.com, nadavh@marvell.com, alior@marvell.com, nitroshift@yahoo.com, jaz@semihalf.com Subject: Re: [PATCH] net: mvneta: fix changing MTU when using per-cpu processing From: David Miller In-Reply-To: <1459516878-2802-1-git-send-email-mw@semihalf.com> References: <1459516878-2802-1-git-send-email-mw@semihalf.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 01 Apr 2016 12:18:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marcin Wojtas Date: Fri, 1 Apr 2016 15:21:18 +0200 > After enabling per-cpu processing it appeared that under heavy load > changing MTU can result in blocking all port's interrupts and transmitting > data is not possible after the change. > > This commit fixes above issue by disabling percpu interrupts for the > time, when TXQs and RXQs are reconfigured. > > Signed-off-by: Marcin Wojtas Applied, thanks. When I reviewed this I was worried that this was yet another case where the ndo op could be invoked in a potentially atomic or similar context, whereby on_each_cpu() would be illegal to use. But that appears to not be the case, and thus this change is just fine. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: davem@davemloft.net (David Miller) Date: Fri, 01 Apr 2016 15:18:20 -0400 (EDT) Subject: [PATCH] net: mvneta: fix changing MTU when using per-cpu processing In-Reply-To: <1459516878-2802-1-git-send-email-mw@semihalf.com> References: <1459516878-2802-1-git-send-email-mw@semihalf.com> Message-ID: <20160401.151820.127036849232206611.davem@davemloft.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org From: Marcin Wojtas Date: Fri, 1 Apr 2016 15:21:18 +0200 > After enabling per-cpu processing it appeared that under heavy load > changing MTU can result in blocking all port's interrupts and transmitting > data is not possible after the change. > > This commit fixes above issue by disabling percpu interrupts for the > time, when TXQs and RXQs are reconfigured. > > Signed-off-by: Marcin Wojtas Applied, thanks. When I reviewed this I was worried that this was yet another case where the ndo op could be invoked in a potentially atomic or similar context, whereby on_each_cpu() would be illegal to use. But that appears to not be the case, and thus this change is just fine. Thanks.