From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757952AbcDABkI (ORCPT ); Thu, 31 Mar 2016 21:40:08 -0400 Received: from mail.kernel.org ([198.145.29.136]:43639 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753675AbcDABkG (ORCPT ); Thu, 31 Mar 2016 21:40:06 -0400 Date: Fri, 1 Apr 2016 09:39:38 +0800 From: Shawn Guo To: Tim Harvey Cc: Guenter Roeck , Akshay Bhat , Fabio Estevam , Rob Herring , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sascha Hauer , Russell King - ARM Linux , "linux-arm-kernel@lists.infradead.org" , Justin Waters , Lucas Stach , Stefan Roese Subject: Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop Message-ID: <20160401013938.GE18833@tiger> References: <20151228162923.GA31680@spo001.leaseweb.nl> <56AA79DA.2010305@timesys.com> <56F991C3.8030201@timesys.com> <20160330012226.GD28207@tiger> <20160330210916.GB21993@roeck-us.net> <20160331015714.GM28207@tiger> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 31, 2016 at 11:01:58AM -0700, Tim Harvey wrote: > On Wed, Mar 30, 2016 at 6:57 PM, Shawn Guo wrote: > > On Wed, Mar 30, 2016 at 02:09:16PM -0700, Guenter Roeck wrote: > >> The question was if the property name should be ext-reset-output or > >> fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output > >> because it is not a generic property. Tim disagrees. > >> > > Guenter, > > My issue regarding the vendor prefix was not a hard dissagreement but > was more about me understanding the rational behind using vendor > prefixes. In this case the imx2_wdt driver 'is' a vendor specific > driver as its compatible strings are prefixed with 'fsl,' so isn't > 'any' property added to devicetree/bindings/watchdog/fsl-imx-wdt.txt > inherently a vendor specific properly already? I assume that is why > the 'big-endian' property isn't 'fsl,big-endian'. We should read it as that 'big-endian' is a generic property defined by generic bindings - bindings/regmap/regmap.txt, and we just reference the bindings in fsl-imx-wdt.txt. Taking mmc bindings as example, bindings/mmc/mmc.txt defines generic bindings, while bindings/mmc/fsl-imx-esdhc.txt defines i.MX vendor specific properties, which should ideally have vendor prefix. Shawn From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop Date: Fri, 1 Apr 2016 09:39:38 +0800 Message-ID: <20160401013938.GE18833@tiger> References: <20151228162923.GA31680@spo001.leaseweb.nl> <56AA79DA.2010305@timesys.com> <56F991C3.8030201@timesys.com> <20160330012226.GD28207@tiger> <20160330210916.GB21993@roeck-us.net> <20160331015714.GM28207@tiger> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tim Harvey Cc: Guenter Roeck , Akshay Bhat , Fabio Estevam , Rob Herring , Wim Van Sebroeck , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Sascha Hauer , Russell King - ARM Linux , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Justin Waters , Lucas Stach , Stefan Roese List-Id: devicetree@vger.kernel.org On Thu, Mar 31, 2016 at 11:01:58AM -0700, Tim Harvey wrote: > On Wed, Mar 30, 2016 at 6:57 PM, Shawn Guo wrote: > > On Wed, Mar 30, 2016 at 02:09:16PM -0700, Guenter Roeck wrote: > >> The question was if the property name should be ext-reset-output or > >> fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output > >> because it is not a generic property. Tim disagrees. > >> > > Guenter, > > My issue regarding the vendor prefix was not a hard dissagreement but > was more about me understanding the rational behind using vendor > prefixes. In this case the imx2_wdt driver 'is' a vendor specific > driver as its compatible strings are prefixed with 'fsl,' so isn't > 'any' property added to devicetree/bindings/watchdog/fsl-imx-wdt.txt > inherently a vendor specific properly already? I assume that is why > the 'big-endian' property isn't 'fsl,big-endian'. We should read it as that 'big-endian' is a generic property defined by generic bindings - bindings/regmap/regmap.txt, and we just reference the bindings in fsl-imx-wdt.txt. Taking mmc bindings as example, bindings/mmc/mmc.txt defines generic bindings, while bindings/mmc/fsl-imx-esdhc.txt defines i.MX vendor specific properties, which should ideally have vendor prefix. Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kernel.org ([198.145.29.136]:43639 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753675AbcDABkG (ORCPT ); Thu, 31 Mar 2016 21:40:06 -0400 Date: Fri, 1 Apr 2016 09:39:38 +0800 From: Shawn Guo To: Tim Harvey Cc: Guenter Roeck , Akshay Bhat , Fabio Estevam , Rob Herring , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sascha Hauer , Russell King - ARM Linux , "linux-arm-kernel@lists.infradead.org" , Justin Waters , Lucas Stach , Stefan Roese Subject: Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop Message-ID: <20160401013938.GE18833@tiger> References: <20151228162923.GA31680@spo001.leaseweb.nl> <56AA79DA.2010305@timesys.com> <56F991C3.8030201@timesys.com> <20160330012226.GD28207@tiger> <20160330210916.GB21993@roeck-us.net> <20160331015714.GM28207@tiger> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Thu, Mar 31, 2016 at 11:01:58AM -0700, Tim Harvey wrote: > On Wed, Mar 30, 2016 at 6:57 PM, Shawn Guo wrote: > > On Wed, Mar 30, 2016 at 02:09:16PM -0700, Guenter Roeck wrote: > >> The question was if the property name should be ext-reset-output or > >> fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output > >> because it is not a generic property. Tim disagrees. > >> > > Guenter, > > My issue regarding the vendor prefix was not a hard dissagreement but > was more about me understanding the rational behind using vendor > prefixes. In this case the imx2_wdt driver 'is' a vendor specific > driver as its compatible strings are prefixed with 'fsl,' so isn't > 'any' property added to devicetree/bindings/watchdog/fsl-imx-wdt.txt > inherently a vendor specific properly already? I assume that is why > the 'big-endian' property isn't 'fsl,big-endian'. We should read it as that 'big-endian' is a generic property defined by generic bindings - bindings/regmap/regmap.txt, and we just reference the bindings in fsl-imx-wdt.txt. Taking mmc bindings as example, bindings/mmc/mmc.txt defines generic bindings, while bindings/mmc/fsl-imx-esdhc.txt defines i.MX vendor specific properties, which should ideally have vendor prefix. Shawn From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawnguo@kernel.org (Shawn Guo) Date: Fri, 1 Apr 2016 09:39:38 +0800 Subject: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop In-Reply-To: References: <20151228162923.GA31680@spo001.leaseweb.nl> <56AA79DA.2010305@timesys.com> <56F991C3.8030201@timesys.com> <20160330012226.GD28207@tiger> <20160330210916.GB21993@roeck-us.net> <20160331015714.GM28207@tiger> Message-ID: <20160401013938.GE18833@tiger> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Mar 31, 2016 at 11:01:58AM -0700, Tim Harvey wrote: > On Wed, Mar 30, 2016 at 6:57 PM, Shawn Guo wrote: > > On Wed, Mar 30, 2016 at 02:09:16PM -0700, Guenter Roeck wrote: > >> The question was if the property name should be ext-reset-output or > >> fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output > >> because it is not a generic property. Tim disagrees. > >> > > Guenter, > > My issue regarding the vendor prefix was not a hard dissagreement but > was more about me understanding the rational behind using vendor > prefixes. In this case the imx2_wdt driver 'is' a vendor specific > driver as its compatible strings are prefixed with 'fsl,' so isn't > 'any' property added to devicetree/bindings/watchdog/fsl-imx-wdt.txt > inherently a vendor specific properly already? I assume that is why > the 'big-endian' property isn't 'fsl,big-endian'. We should read it as that 'big-endian' is a generic property defined by generic bindings - bindings/regmap/regmap.txt, and we just reference the bindings in fsl-imx-wdt.txt. Taking mmc bindings as example, bindings/mmc/mmc.txt defines generic bindings, while bindings/mmc/fsl-imx-esdhc.txt defines i.MX vendor specific properties, which should ideally have vendor prefix. Shawn