From: Leon Romanovsky <leon-2ukJVAZIZ/Y@public.gmane.org>
To: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Nicholas A. Bellinger"
<nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH for kernel v4.6] IB/srpt: Revert "Convert to percpu_ida tag allocation"
Date: Fri, 1 Apr 2016 06:03:22 +0300 [thread overview]
Message-ID: <20160401030322.GH2670@leon.nu> (raw)
In-Reply-To: <56FDBA63.7010804-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
On Thu, Mar 31, 2016 at 05:01:39PM -0700, Bart Van Assche wrote:
> That patch is wrong because it makes the ib_srpt driver use I/O
> contexts allocated by transport_alloc_session_tags() but it does
> not initialize these I/O contexts properly.
Did you have a chance to see which initializations are missing in this
case? What is needed to do if we decide to fix original patch?
Except these questions, the revert is fine :)
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-04-01 3:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 0:01 [PATCH for kernel v4.6] IB/srpt: Revert "Convert to percpu_ida tag allocation" Bart Van Assche
[not found] ` <56FDBA63.7010804-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-04-01 3:03 ` Leon Romanovsky [this message]
[not found] ` <20160401030322.GH2670-2ukJVAZIZ/Y@public.gmane.org>
2016-04-01 3:12 ` Bart Van Assche
[not found] ` <56FDE739.9090801-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-04-01 3:45 ` leon-2ukJVAZIZ/Y
2016-04-03 3:56 ` Nicholas A. Bellinger
[not found] ` <1459655763.13184.45.camel-XoQW25Eq2zviZyQQd+hFbcojREIfoBdhmpATvIKMPHk@public.gmane.org>
2016-04-03 13:13 ` sagig
[not found] ` <570116E0.3010401-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-04-04 18:34 ` Nicholas A. Bellinger
2016-04-03 14:26 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160401030322.GH2670@leon.nu \
--to=leon-2ukjvaziz/y@public.gmane.org \
--cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.