All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] vfs: constify arguments to utime family of system calls
Date: Fri, 1 Apr 2016 04:30:06 +0100	[thread overview]
Message-ID: <20160401033006.GB17997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20160401022457.GC1323@zzz>

On Thu, Mar 31, 2016 at 09:24:57PM -0500, Eric Biggers wrote:

> I feel it's a small improvement as it reduces the chance of bugs.  However, if
> you look at all the system calls, they are, in general, inconsistent about using
> 'const'.  So may be right that changing just a few isn't worthwhile.

It might very well be worth doing a full series, though - after all,
they are not hard to grep for ((COMPAT_)?SYSCALL_DEFINE[0-6] would get
you almost all of them, with rest consisting of weird shit in arch/*
that more often than not would be better off switched to SYSCALL_DEFINE).

The reason why it's worth doing completely or not at all is that partial
series will serve as an invitation to the alt.sex.masturbation.commit.count
crowd, with the usual quality of output...

      reply	other threads:[~2016-04-01  3:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01  1:51 [PATCH v2] vfs: constify arguments to utime family of system calls Eric Biggers
2016-04-01  2:05 ` Al Viro
2016-04-01  2:24   ` Eric Biggers
2016-04-01  3:30     ` Al Viro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160401033006.GB17997@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=ebiggers3@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.