From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alq7b-0008Mn-KA for qemu-devel@nongnu.org; Thu, 31 Mar 2016 23:51:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alq7X-0002X9-Ao for qemu-devel@nongnu.org; Thu, 31 Mar 2016 23:51:43 -0400 Date: Fri, 1 Apr 2016 14:34:48 +1100 From: David Gibson Message-ID: <20160401033448.GN416@voom.redhat.com> References: <1459352314-12552-1-git-send-email-clg@fr.ibm.com> <20160331045542.GB416@voom.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="e8/wErwm0bqugfcz" Content-Disposition: inline In-Reply-To: <20160331045542.GB416@voom.redhat.com> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] spapr: compute interrupt vector address from LPCR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: Thomas Huth , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Greg Kurz --e8/wErwm0bqugfcz Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 31, 2016 at 03:55:42PM +1100, David Gibson wrote: > On Wed, Mar 30, 2016 at 05:38:34PM +0200, C=E9dric Le Goater wrote: > > This address is changed by the linux kernel using the H_SET_MODE hcall > > and needs to be restored when migrating a spapr VM running in > > TCG. This can be done using the AIL bits from the LPCR register. > >=20 > > The patch introduces a helper routine cpu_ppc_get_excp_prefix() which > > returns the effective address offset of the interrupt handler > > depending on the LPCR_AIL bits. The same helper can be used in the > > H_SET_MODE hcall, which lets us remove the H_SET_MODE_ADDR_TRANS_* > > defines. > >=20 > > Signed-off-by: C=E9dric Le Goater >=20 > I've applied this (with Greg's minor amendments) to ppc-for-2.6), > since it certainly improves behaviour, although I have a couple of > queries: And.. I've take it out again now. In addition to the fact that I'd like some rework suggested elsewhere, it breaks compile for 32-bit ppc targets. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --e8/wErwm0bqugfcz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW/exYAAoJEGw4ysog2bOSruIP/2HtOldHZkK4vwphRwpu+HEd 4agcHDlx122F8qamWVpGaJJ0V5cqUS5SDJLaFPSxQDGk/P9UKS2zURHRwzmtA99O cixsZuWxwp05FSMxZWEF2J+Rkxea/dtHtp79BQYkZyU3XlgrPMhC6PVmXM4KwLTp qXHsJ0wL1SUa4c8c5OgwEieEr0bDgc0/5im39G95tK6Wtcip/bqqvPR/RqntPIiz a12sGOr5zTWSv8IVStS/1upuMc1ZUJAf2+4KhGUoSKZMlgXAcXacaKhvRLKhpgXp yJFrcj36zE/HzM1lYKyB+GM4ApV8jyNqeL4YpiVETCpY/JMlQNMr+qHy6N3k7TZN 0QMUj2RE02f4b4CNTvQjYJSrk0gk/wOd8ymDZHPgGBcOUrR+SBHBKZ1rjhncxbWs q1lkdXzdojXFE9Q5aCwUT2OppJRnAj3lovi8L9h2BhcThh7QKvnX5MBIlOHd4KcN 1uH3PLYbjc6VMejuCWBkR4xW5yQaVhSj5J7IYQg66XiOUnrfrH3CtJvfi1MHoY60 NFMk1o4Tx7IcHSQcONGFOEb60IMVVAi0WxSmos/hDKMarWT2atjYa/1EOcm0Db0g CfUNCKfPwo+K1+yQOKFjkdGlBqxNoatudmmbv629IvBttiwQfrs0GQehtmKfdDll yrKkJSYHd0o4YabfI9MX =EAJJ -----END PGP SIGNATURE----- --e8/wErwm0bqugfcz--