From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 1 Apr 2016 19:41:04 -0400 Subject: [U-Boot] [PATCH 3/9] drivers: nand: Kconfig: add NAND as Kconfig option In-Reply-To: <1459552038.32510.39.camel@buserror.net> References: <1459510190-26306-1-git-send-email-mugunthanvnm@ti.com> <1459510190-26306-4-git-send-email-mugunthanvnm@ti.com> <20160401125141.GP23166@bill-the-cat> <1459552038.32510.39.camel@buserror.net> Message-ID: <20160401234104.GI23166@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Apr 01, 2016 at 06:07:18PM -0500, Scott Wood wrote: > On Fri, 2016-04-01 at 08:51 -0400, Tom Rini wrote: > > On Fri, Apr 01, 2016 at 04:59:44PM +0530, Mugunthan V N wrote: > > > > > Add CONFIG_NAND as a Kconfig option so that it can be selected > > > using menuconfig or defconfig. > > > > > > Signed-off-by: Mugunthan V N > > > > Good but you need to update configs/ to remove NAND from > > CONFIG_SYS_EXTRA_OPTIONS and add CONFIG_NAND=y > > NACK > > That CONFIG_NAND is a target-local option used by some boards to indicate boot > source. It is not equivalent to CONFIG_CMD_NAND which is what enables the > NAND subsystem. Exactly! We need to have 'NAND' moved from CONFIG_SYS_EXTRA_OPTIONS and into a real Kconfig entry. That said, I think this might have forgotten to enable it in other places too but just 'NAND' needs to migrate out of where it is. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: