All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: aduyck@mirantis.com, tom@herbertland.com, jesse@kernel.org,
	alexander.duyck@gmail.com, edumazet@google.com,
	netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [net PATCH 2/2] ipv4/GRO: Make GRO conform to RFC 6864
Date: Sat, 2 Apr 2016 09:57:10 +0800	[thread overview]
Message-ID: <20160402015709.GA19365@gondor.apana.org.au> (raw)
In-Reply-To: <1459536543.6473.289.camel@edumazet-glaptop3.roam.corp.google.com>

Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
> I do not particularly care, but it is worth mentioning that GRO+TSO
> would not be idempotent anymore.

We could easily fix that by adding a feature bit to control this,
something like SKB_GSO_TCP_FIXEDID.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  parent reply	other threads:[~2016-04-02  1:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01 18:05 [net PATCH 0/2] Fixes for GRO and GRE tunnels Alexander Duyck
2016-04-01 18:05 ` [net PATCH 1/2] GRE: Disable segmentation offloads w/ CSUM and we are encapsulated via FOU Alexander Duyck
2016-04-01 18:05 ` [net PATCH 2/2] ipv4/GRO: Make GRO conform to RFC 6864 Alexander Duyck
2016-04-01 18:49   ` Eric Dumazet
2016-04-01 19:24     ` David Miller
2016-04-01 19:58       ` Alexander Duyck
2016-04-01 21:13         ` Subash Abhinov Kasiviswanathan
2016-04-02  2:16         ` David Miller
2016-04-02  2:21           ` Eric Dumazet
2016-04-02 20:26             ` Rick Jones
2016-04-02  6:02           ` Alexander Duyck
2016-04-02  1:57     ` Herbert Xu [this message]
2016-04-02  2:15       ` Eric Dumazet
2016-04-02  2:19         ` Herbert Xu
2016-04-02  2:26           ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160402015709.GA19365@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=aduyck@mirantis.com \
    --cc=alexander.duyck@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=jesse@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tom@herbertland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.