All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] fluentbit: add new recipe
Date: Sat, 2 Apr 2016 20:17:14 +0200	[thread overview]
Message-ID: <20160402181714.GG2567@jama> (raw)
In-Reply-To: <CAEaCVQjW0cmMDNyc3LhZQxv+RWfVmx9Bj-qgQx9AH1_+0=sTDA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3430 bytes --]

On Fri, Apr 01, 2016 at 11:20:49AM -0600, Eduardo Silva wrote:
> on this case should be "RDEPENDS_${PN} = "zlib" OK ?

NO

> On Fri, Apr 1, 2016 at 11:01 AM, Eduardo Silva <eduardo@monkey.io> wrote:
> 
> > Oh, sorry I misunderstood. The program requires zlib to run, so it's a
> > build (headers) and runtime dependency.
> >
> > On Fri, Apr 1, 2016 at 10:57 AM, Martin Jansa <martin.jansa@gmail.com>
> > wrote:
> >
> >> Then it's probably build time dependency as the warning says, not runtime
> >> dependency like you did.
> >>
> >> Read what the component build does, if it checks for zlib in configure
> >> then
> >> you really need to add it to DEPENDS not RDEPENDS_${PN}.
> >>
> >> On Fri, Apr 1, 2016 at 6:53 PM, Eduardo Silva <eduardo@monkey.io> wrote:
> >>
> >> > > +LIC_FILES_CHKSUM =
> >> > "file://${S}/LICENSE;md5=2ee41112a44fe7014dce33e26468ba93"
> >> >
> >> > >
> >> > > LIC_FILES_CHKSUM is relative to ${S}, so LIC_FILES_CHKSUM =
> >> > > "file://LICENSE.. should work fine
> >> > >
> >> > >
> >> > Thanks, I have updated my local copy
> >> >
> >> >
> >> > > > +
> >> > > > +RDEPENDS_${PN} = "zlib"
> >> > >
> >> > > If it does link with libz then the runtime dependency should be added
> >> > > automatically by shlibs code in package.bbclass if it's not the case
> >> > > can you add comment explaining why it needs to be added explicitly?
> >> > >
> >> > >
> >> > I added that because I got a QA warning message:
> >> >
> >> > WARNING: QA Issue: fluentbit-dev rdepends on zlib, but it isn't a build
> >> > dependency? [build-deps]
> >> > WARNING: QA Issue: fluentbit rdepends on zlib, but it isn't a build
> >> > dependency? [build-deps]
> >> >
> >> > what's your suggestion in this case ?
> >> >
> >> > best
> >> >
> >> >
> >> >
> >> > > > +
> >> > > > +inherit cmake
> >> > > > --
> >> > > > 2.5.0
> >> > > >
> >> > > > --
> >> > > > _______________________________________________
> >> > > > Openembedded-devel mailing list
> >> > > > Openembedded-devel@lists.openembedded.org
> >> > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >> > >
> >> > > --
> >> > > Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> >> > >
> >> > > --
> >> > > _______________________________________________
> >> > > Openembedded-devel mailing list
> >> > > Openembedded-devel@lists.openembedded.org
> >> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >> > >
> >> > >
> >> >
> >> >
> >> > --
> >> > Eduardo Silva
> >> > Monkey Software
> >> > --
> >> > _______________________________________________
> >> > Openembedded-devel mailing list
> >> > Openembedded-devel@lists.openembedded.org
> >> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >> >
> >> --
> >> _______________________________________________
> >> Openembedded-devel mailing list
> >> Openembedded-devel@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >>
> >
> >
> >
> > --
> > Eduardo Silva
> > Monkey Software
> >
> 
> 
> 
> -- 
> Eduardo Silva
> Monkey Software
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

  reply	other threads:[~2016-04-02 18:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-31  6:42 [meta-oe][PATCH] fluentbit: add new recipe Eduardo Silva
2016-04-01 13:38 ` Martin Jansa
2016-04-01 16:53   ` Eduardo Silva
2016-04-01 16:57     ` Martin Jansa
2016-04-01 17:01       ` Eduardo Silva
2016-04-01 17:20         ` Eduardo Silva
2016-04-02 18:17           ` Martin Jansa [this message]
2016-04-04 20:46             ` Paul Eggleton
2016-04-04 20:48               ` Eduardo Silva
2016-04-06 10:41                 ` Felipe Ferreri Tonello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160402181714.GG2567@jama \
    --to=martin.jansa@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.