From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752233AbcDCDqY (ORCPT ); Sat, 2 Apr 2016 23:46:24 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:34912 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819AbcDCDqW (ORCPT ); Sat, 2 Apr 2016 23:46:22 -0400 Date: Sun, 3 Apr 2016 12:46:15 +0900 From: Krzysztof Kozlowski To: Rob Herring Cc: Krzysztof Kozlowski , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Kukjin Kim , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" Subject: Re: [PATCH 01/11] ARM: dts: exynos: Fix DTC unit name warnings in cros-adc-thermistors Message-ID: <20160403034615.GC4919@kozik-lap> References: <1459493874-2366-1-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 01, 2016 at 10:31:34AM -0500, Rob Herring wrote: > On Fri, Apr 1, 2016 at 1:57 AM, Krzysztof Kozlowski > wrote: > > Fix following DTC warnings in cros-adc-thermistors: > > Warning (unit_address_vs_reg): Node /adc@12D10000/ncp15wb473@3 has a unit name, but no reg property > > Warning (unit_address_vs_reg): Node /adc@12D10000/ncp15wb473@4 has a unit name, but no reg property > > Warning (unit_address_vs_reg): Node /adc@12D10000/ncp15wb473@5 has a unit name, but no reg property > > Warning (unit_address_vs_reg): Node /adc@12D10000/ncp15wb473@6 has a unit name, but no reg property > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > arch/arm/boot/dts/cros-adc-thermistors.dtsi | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm/boot/dts/cros-adc-thermistors.dtsi b/arch/arm/boot/dts/cros-adc-thermistors.dtsi > > index acd4fe1833f2..87e676917603 100644 > > --- a/arch/arm/boot/dts/cros-adc-thermistors.dtsi > > +++ b/arch/arm/boot/dts/cros-adc-thermistors.dtsi > > @@ -13,28 +13,28 @@ > > */ > > > > &adc { > > - ncp15wb473@3 { > > + ncp15wb473_3 { > > Don't use underscores. The ePAPR lists underscore as a acceptable character... but if you insists then the sensible solution would be to rename all the nodes to something like: - ncp15wb473@3 { + thermistor3 { Is it okay? > > > compatible = "murata,ncp15wb473"; > > pullup-uv = <1800000>; > > pullup-ohm = <47000>; > > pulldown-ohm = <0>; > > io-channels = <&adc 3>; > > I've not looked at the full binding here, but this case may warrant > adding a reg property as an ADC channel number is what i'd consider an > addressable thing. This does not look entirely as an addressable thing. Altough this particular driver (ntc_thermistor.c) uses one iio-channel... but others are often using more than one. > This is also kind of strange having a phandle to > the parent node. The Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt mentions that sensors can be added as child nodes or separately. The exynos_adc driver indeed calls of_platform_populate() but I am not sure why this was added. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 01/11] ARM: dts: exynos: Fix DTC unit name warnings in cros-adc-thermistors Date: Sun, 3 Apr 2016 12:46:15 +0900 Message-ID: <20160403034615.GC4919@kozik-lap> References: <1459493874-2366-1-git-send-email-k.kozlowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: Rob Herring Cc: Krzysztof Kozlowski , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Kukjin Kim , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" List-Id: devicetree@vger.kernel.org On Fri, Apr 01, 2016 at 10:31:34AM -0500, Rob Herring wrote: > On Fri, Apr 1, 2016 at 1:57 AM, Krzysztof Kozlowski > wrote: > > Fix following DTC warnings in cros-adc-thermistors: > > Warning (unit_address_vs_reg): Node /adc@12D10000/ncp15wb473@3 has a unit name, but no reg property > > Warning (unit_address_vs_reg): Node /adc@12D10000/ncp15wb473@4 has a unit name, but no reg property > > Warning (unit_address_vs_reg): Node /adc@12D10000/ncp15wb473@5 has a unit name, but no reg property > > Warning (unit_address_vs_reg): Node /adc@12D10000/ncp15wb473@6 has a unit name, but no reg property > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > arch/arm/boot/dts/cros-adc-thermistors.dtsi | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm/boot/dts/cros-adc-thermistors.dtsi b/arch/arm/boot/dts/cros-adc-thermistors.dtsi > > index acd4fe1833f2..87e676917603 100644 > > --- a/arch/arm/boot/dts/cros-adc-thermistors.dtsi > > +++ b/arch/arm/boot/dts/cros-adc-thermistors.dtsi > > @@ -13,28 +13,28 @@ > > */ > > > > &adc { > > - ncp15wb473@3 { > > + ncp15wb473_3 { > > Don't use underscores. The ePAPR lists underscore as a acceptable character... but if you insists then the sensible solution would be to rename all the nodes to something like: - ncp15wb473@3 { + thermistor3 { Is it okay? > > > compatible = "murata,ncp15wb473"; > > pullup-uv = <1800000>; > > pullup-ohm = <47000>; > > pulldown-ohm = <0>; > > io-channels = <&adc 3>; > > I've not looked at the full binding here, but this case may warrant > adding a reg property as an ADC channel number is what i'd consider an > addressable thing. This does not look entirely as an addressable thing. Altough this particular driver (ntc_thermistor.c) uses one iio-channel... but others are often using more than one. > This is also kind of strange having a phandle to > the parent node. The Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt mentions that sensors can be added as child nodes or separately. The exynos_adc driver indeed calls of_platform_populate() but I am not sure why this was added. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Sun, 3 Apr 2016 12:46:15 +0900 Subject: [PATCH 01/11] ARM: dts: exynos: Fix DTC unit name warnings in cros-adc-thermistors In-Reply-To: References: <1459493874-2366-1-git-send-email-k.kozlowski@samsung.com> Message-ID: <20160403034615.GC4919@kozik-lap> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Apr 01, 2016 at 10:31:34AM -0500, Rob Herring wrote: > On Fri, Apr 1, 2016 at 1:57 AM, Krzysztof Kozlowski > wrote: > > Fix following DTC warnings in cros-adc-thermistors: > > Warning (unit_address_vs_reg): Node /adc at 12D10000/ncp15wb473 at 3 has a unit name, but no reg property > > Warning (unit_address_vs_reg): Node /adc at 12D10000/ncp15wb473 at 4 has a unit name, but no reg property > > Warning (unit_address_vs_reg): Node /adc at 12D10000/ncp15wb473 at 5 has a unit name, but no reg property > > Warning (unit_address_vs_reg): Node /adc at 12D10000/ncp15wb473 at 6 has a unit name, but no reg property > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > arch/arm/boot/dts/cros-adc-thermistors.dtsi | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm/boot/dts/cros-adc-thermistors.dtsi b/arch/arm/boot/dts/cros-adc-thermistors.dtsi > > index acd4fe1833f2..87e676917603 100644 > > --- a/arch/arm/boot/dts/cros-adc-thermistors.dtsi > > +++ b/arch/arm/boot/dts/cros-adc-thermistors.dtsi > > @@ -13,28 +13,28 @@ > > */ > > > > &adc { > > - ncp15wb473 at 3 { > > + ncp15wb473_3 { > > Don't use underscores. The ePAPR lists underscore as a acceptable character... but if you insists then the sensible solution would be to rename all the nodes to something like: - ncp15wb473 at 3 { + thermistor3 { Is it okay? > > > compatible = "murata,ncp15wb473"; > > pullup-uv = <1800000>; > > pullup-ohm = <47000>; > > pulldown-ohm = <0>; > > io-channels = <&adc 3>; > > I've not looked at the full binding here, but this case may warrant > adding a reg property as an ADC channel number is what i'd consider an > addressable thing. This does not look entirely as an addressable thing. Altough this particular driver (ntc_thermistor.c) uses one iio-channel... but others are often using more than one. > This is also kind of strange having a phandle to > the parent node. The Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt mentions that sensors can be added as child nodes or separately. The exynos_adc driver indeed calls of_platform_populate() but I am not sure why this was added. Best regards, Krzysztof