From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932105AbcDDFRE (ORCPT ); Mon, 4 Apr 2016 01:17:04 -0400 Received: from mail.kernel.org ([198.145.29.136]:50207 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751779AbcDDFQ5 (ORCPT ); Mon, 4 Apr 2016 01:16:57 -0400 Date: Mon, 4 Apr 2016 00:16:47 -0500 From: Rob Herring To: Guodong Xu Cc: xuwei5@hisilicon.com, mark.rutland@arm.com, grant.likely@secretlab.ca, linus.walleij@linaro.org, arnd.bergmann@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kong.kongxinwei@hisilicon.com Subject: Re: [PATCH v2 08/16] arm64: dts: hikey: enable i2c0 and i2c1 for working with mezzanine boards Message-ID: <20160404051647.GS17806@rob-hp-laptop> References: <1459589383-16914-1-git-send-email-guodong.xu@linaro.org> <1459589383-16914-9-git-send-email-guodong.xu@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459589383-16914-9-git-send-email-guodong.xu@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 02, 2016 at 05:29:35PM +0800, Guodong Xu wrote: > Signed-off-by: Guodong Xu > --- > arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > index 5c9ee31..e00e9ec 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > @@ -42,6 +42,15 @@ > <0x00000000 0x06e00000 0x00000000 0x0060f000>, > <0x00000000 0x07410000 0x00000000 0x36bf0000>; > }; > + > + soc { > + i2c0: i2c@f7100000 { > + status = "ok"; > + }; > + i2c1: i2c@f7101000 { > + status = "ok"; > + }; Do these go to LS connector? If so, add 'label = "LS-I2C0";' or LS-I2C1 as appropriate (based on LS connector numbering). Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Mon, 4 Apr 2016 00:16:47 -0500 Subject: [PATCH v2 08/16] arm64: dts: hikey: enable i2c0 and i2c1 for working with mezzanine boards In-Reply-To: <1459589383-16914-9-git-send-email-guodong.xu@linaro.org> References: <1459589383-16914-1-git-send-email-guodong.xu@linaro.org> <1459589383-16914-9-git-send-email-guodong.xu@linaro.org> Message-ID: <20160404051647.GS17806@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Apr 02, 2016 at 05:29:35PM +0800, Guodong Xu wrote: > Signed-off-by: Guodong Xu > --- > arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > index 5c9ee31..e00e9ec 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > @@ -42,6 +42,15 @@ > <0x00000000 0x06e00000 0x00000000 0x0060f000>, > <0x00000000 0x07410000 0x00000000 0x36bf0000>; > }; > + > + soc { > + i2c0: i2c at f7100000 { > + status = "ok"; > + }; > + i2c1: i2c at f7101000 { > + status = "ok"; > + }; Do these go to LS connector? If so, add 'label = "LS-I2C0";' or LS-I2C1 as appropriate (based on LS connector numbering). Rob