From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anAJZ-0003A9-Ba for qemu-devel@nongnu.org; Mon, 04 Apr 2016 15:37:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anAJY-0006ME-J8 for qemu-devel@nongnu.org; Mon, 04 Apr 2016 15:37:33 -0400 Date: Mon, 4 Apr 2016 16:37:23 -0300 From: Eduardo Habkost Message-ID: <20160404193723.GD22665@thinpad.lan.raisama.net> References: <1458910214-12239-1-git-send-email-aleksandar.markovic@rt-rk.com> <1458910214-12239-2-git-send-email-aleksandar.markovic@rt-rk.com> <56F9A3D1.2050402@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 1/2] softfloat: Enable run-time-configurable meaning of signaling NaN bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "proljc@gmail.com" , "kbastian@mail.uni-paderborn.de" , "mark.cave-ayland@ilande.co.uk" , "qemu-devel@nongnu.org" , "agraf@suse.de" , "blauwirbel@gmail.com" , "jcmvbkbc@gmail.com" , Aleksandar Markovic , "qemu-arm@nongnu.org" , "qemu-ppc@nongnu.org" , Petar Jovanovic , "pbonzini@redhat.com" , Miodrag Dinic , "edgar.iglesias@gmail.com" , "gxt@mprc.pku.edu.cn" , Leon Alrae , "afaerber@suse.de" , "aurelien@aurel32.net" , Richard Henderson On Mon, Apr 04, 2016 at 02:31:47PM +0100, Peter Maydell wrote: > On 4 April 2016 at 14:21, Aleksandar Markovic > wrote: > > B. arm - explicitely sets other fields of float_status, > > explicit invocation of set_snan_bit_is_one(0) added > > We zero the float_status structs on reset, because they are earlier > in the CPUARMState structure than the 'features' field (and so the > memset() in arm_cpu_reset() will clear them). So you don't > need to explicitly zero a field like this. I expect the other > architectures are the same. Even if it is not zeroed on reset, it is zeroed on object_new(). Isn't that enough? -- Eduardo