All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Filipe Manana <fdmanana@gmail.com>
Cc: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>,
	"dsterba@suse.cz" <dsterba@suse.cz>,
	linux-btrfs <linux-btrfs@vger.kernel.org>,
	"Chris Mason" <clm@fb.com>, "David Sterba" <dsterba@suse.com>
Subject: Re: [PATCH] delete obsolete function btrfs_print_tree()
Date: Mon, 4 Apr 2016 23:10:17 +0300	[thread overview]
Message-ID: <20160404201017.GA5502@mwanda> (raw)
In-Reply-To: <CAL3q7H5XDU2sNEVmYYsc7L72zCbN7Dpdx-nsSETwdJQd529z0A@mail.gmail.com>

On Mon, Apr 04, 2016 at 05:02:38PM +0100, Filipe Manana wrote:
> It's not serious if it doesn't have all the proper error handling
> and etc, it's just something for debugging purposes.

I'm slowly trying to remove static checker warnings so that we can
detect real bugs.  People sometimes leave little messages for me in
their code because they know I will review the new warning:

	foo = kmalloc();
	/* error handling deliberately left out */

It make me quite annoyed because it's like "Oh.  No if we added error
handling that would take 40 extra bytes of memory!  Such a waste!"  But
we could use instead use___GFP_NOFAIL instead.  Or BUG_ON(!foo)".  I
have gotten distracted.  What was the question again?

regards,
dan carpenter


      parent reply	other threads:[~2016-04-04 20:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-25 14:53 [PATCH] delete obsolete function btrfs_print_tree() Holger Hoffstätte
2016-04-04 13:56 ` David Sterba
2016-04-04 15:54   ` Holger Hoffstätte
2016-04-04 16:02     ` Filipe Manana
2016-04-04 16:20       ` Holger Hoffstätte
2016-04-04 20:10       ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160404201017.GA5502@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=dsterba@suse.cz \
    --cc=fdmanana@gmail.com \
    --cc=holger.hoffstaette@googlemail.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.