From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 4 Apr 2016 20:01:54 -0400 Subject: [U-Boot] [PATCH] sf: fix timebase data type in _wait_ready() In-Reply-To: <1459789432-13372-1-git-send-email-swarren@wwwdotorg.org> References: <1459789432-13372-1-git-send-email-swarren@wwwdotorg.org> Message-ID: <20160405000154.GB23166@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Apr 04, 2016 at 11:03:52AM -0600, Stephen Warren wrote: > From: Stephen Warren > > get_timer() returns an unsigned 64-bit value, but is currently assigned to > a signed 32-bit variable. Due to sign extension and data truncation, this > causes the timeout loop in spi_flash_cmd_wait_ready() to immediately (and > incorrectly) fire for about 50% of all time values, based on whether bit > 31 is set. In sandbox at least, this causes the test to pass or fail based > on system uptime, as opposed to time since the U-Boot binary was started. > > Fixes: 4efad20a1751 ("sf: Update status reg check in spi_flash_cmd_wait_ready") > Signed-off-by: Stephen Warren Reviewed-by: Tom Rini -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: