From: Herbert Xu <herbert@gondor.apana.org.au>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
jwboyer@linux.vnet.ibm.com, mpm@selenic.com
Subject: Re: crash in ppc4xx-rng on canyonland
Date: Tue, 5 Apr 2016 20:11:19 +0800 [thread overview]
Message-ID: <20160405121118.GA12591@gondor.apana.org.au> (raw)
In-Reply-To: <2309246.SDn0H6XuZk@debian64>
Christian Lamparter <chunkeey@googlemail.com> wrote:
>
> The crash is caused by a bad read in ppc4xx_rng_enable [0]. From what I
> can tell, the driver is mapping the crypto control registers. The
> problem is that they are claimed by the main crypto driver: crypto4xx [1].
>
> I'm not sure what to do in this case. In my opinion the crypto4xx driver
> should just initialize the trng [see patch]. I would like to move the
> trng into the crypto-ppc4xx, but given that this breaks some of the DTS
> out there I'm not sure.
I think you'll also need to ensure that the crypto module is
successfully loaded before the RNG is accessed.
It's probably easier to just merge the two drivers but still
maintaining the original driver names.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-04-05 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 18:29 crash in ppc4xx-rng on canyonland Christian Lamparter
2016-04-05 12:11 ` Herbert Xu [this message]
2016-04-08 22:28 ` Christian Lamparter
2016-04-18 9:59 ` Herbert Xu
2016-04-18 11:42 ` Christian Lamparter
2016-04-20 9:58 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160405121118.GA12591@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=chunkeey@googlemail.com \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.