From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 3/3] drm/i915: Only grab correct forcewake for the engine with execlists Date: Thu, 7 Apr 2016 15:24:31 +0100 Message-ID: <20160407142431.GE18061@nuc-i3427.alporthouse.com> References: <1460037940-14094-1-git-send-email-tvrtko.ursulin@linux.intel.com> <1460037940-14094-3-git-send-email-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id E036C6E39E for ; Thu, 7 Apr 2016 14:24:37 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1460037940-14094-3-git-send-email-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMDcsIDIwMTYgYXQgMDM6MDU6NDBQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gQEAgLTIwOTksNiArMjEwMSwxMiBAQCBsb2dpY2FsX3JpbmdfaW5pdChzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIAo+ICAJ bG9naWNhbF9yaW5nX2luaXRfcGxhdGZvcm1faW52YXJpYW50cyhlbmdpbmUpOwo+ICAKPiArCWVu Z2luZS0+ZndfZG9tYWluc19lbHNwID0KPiArCQlpbnRlbF9yZWdfd3JpdGVfZndfZG9tYWlucyhk ZXZfcHJpdiwgUklOR19FTFNQKGVuZ2luZSkpOwo+ICsJZW5naW5lLT5md19kb21haW5zX2NzYiA9 Cj4gKwkJaW50ZWxfcmVnX3dyaXRlX2Z3X2RvbWFpbnMoZGV2X3ByaXYsCj4gKwkJCQkJICAgUklO R19DT05URVhUX1NUQVRVU19QVFIoZW5naW5lKSk7CgpTbyBpcyB3cml0ZSBhIHN1cGVyc2V0IG9m IGZ3PyBUZW5kcyB0byBiZSByZWFkcyB0aGF0IHJlcXVpcmUgZncgbW9yZQp0aGFuIHdyaXRlcyAo Z2VuNi83IGZpZm8sIGdlbjggd3JpdGUgc2hhZG93aW5nKS4KCkkgdGhpbmsgd2UgbmVlZCBhIFJF QUQgfCBXUklURSBkaXJlY3Rpb24gZmllbGQuCgo+ICsvKioKPiArICogaW50ZWxfcmVnX3dyaXRl X2Z3X2RvbWFpbnMgLSB3aGljaCBmb3JjZXdha2UgZG9tYWlucyBhcmUgbmVlZGVkIHRvIHdyaXRl IGEgcmVnaXN0ZXIKPiArICogQGRldl9wcml2OiBwb2ludGVyIHRvIHN0cnVjdCBkcm1faTkxNV9w cml2YXRlCj4gKyAqIEByZWc6IHJlZ2lzdGVyIGluIHF1ZXN0aW9uCj4gKyAqCj4gKyAqIFJldHVy bnMgYSBzZXQgb2YgZm9yY2V3YWtlIGRvbWFpbnMgcmVxdWlyZWQgdG8gYmUgdGFrZW4gd2l0aCBm b3IgZXhhbXBsZQo+ICsgKiBpbnRlbF91bmNvcmVfZm9yY2V3YWtlX2dldCBmb3IgdGhlIHNwZWNp ZmllZCByZWdpc3RlciB0byBiZSB3cml0YWJsZSB3aXRoIHRoZQo+ICsgKiByYXcgbW1pbyBhY2Nl c3NvcnMuCj4gKyAqLwo+ICtlbnVtIGZvcmNld2FrZV9kb21haW5zCj4gK2ludGVsX3JlZ193cml0 ZV9md19kb21haW5zKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgaTkxNV9yZWdf dCByZWcpCj4gK3sKPiArCWVudW0gZm9yY2V3YWtlX2RvbWFpbnMgZndfZG9tYWluczsKPiArCj4g KwlpZiAoaW50ZWxfdmdwdV9hY3RpdmUoZGV2X3ByaXYtPmRldikpCj4gKwkJcmV0dXJuIDA7Cj4g Kwo+ICsJc3dpdGNoIChJTlRFTF9JTkZPKGRldl9wcml2KS0+Z2VuKSB7Cj4gKwljYXNlIDk6Cj4g KwkJZndfZG9tYWlucyA9IF9fZ2VuOV9yZWdfd3JpdGVfZndfZG9tYWlucyhpOTE1X21taW9fcmVn X29mZnNldChyZWcpKTsKPiArCQlicmVhazsKPiArCWNhc2UgODoKPiArCQlpZiAoSVNfQ0hFUlJZ VklFVyhkZXZfcHJpdikpCj4gKwkJCWZ3X2RvbWFpbnMgPSBfX2Nodl9yZWdfd3JpdGVfZndfZG9t YWlucyhpOTE1X21taW9fcmVnX29mZnNldChyZWcpKTsKPiArCQllbHNlCj4gKwkJCWZ3X2RvbWFp bnMgPSBfX2dlbjhfcmVnX3dyaXRlX2Z3X2RvbWFpbnMoaTkxNV9tbWlvX3JlZ19vZmZzZXQocmVn KSk7Cj4gKwkJYnJlYWs7Cj4gKwlkZWZhdWx0Ogo+ICsJCU1JU1NJTkdfQ0FTRShJTlRFTF9JTkZP KGRldl9wcml2KS0+Z2VuKTsKPiArCWNhc2UgNzoKPiArCWNhc2UgNjoKClRoaXMgaXMgYWN0dWFs bHkgYSB0cmlja3kgb25lLiBnZW42LzcgbWFpbnRhaW4gYSBGSUZPIHRvIHN0b3JlIG1taW8Kd3Jp dGVzIHdoaWxzdCBpdCBpcyBwb3dlcmVkIGRvd24uIElmIHdlIGZpbGwgdGhhdCBmaWZvIHdlIGRy b3Agd3JpdGVzCihhbmQgdGhhdCBmaWZvIGlzIHNoYXJlZCB3aXRoIGZ1bmN0aW9ucyBvbiB0aGUg ZGV2aWNlLCBpLmUuIGl0IGlzIG5vdApvdXJzIHRvIGZpbGwgZXhjbHVzaXZlbHkpLiBTbyBzaG91 bGQgd2UgYmUgc2F2aW5nIHRoYXQgaWYgeW91IHdhbnQgdG8KbWFrZSBsb3RzIG9mIHdyaXRlcyB5 b3Ugc2hvdWxkIHRha2UgdGhpcyBmb3JjZXdha2UgZG9tYWluLiBZZXMuIFdlIHNob3VsZApyZXBv cnQgd2hhdCBkb21haW5zIHRoZXkgd291bGQgcmVxdWlyZSwgaXQgaXMgc3RpbGwgdXAgdG8gdGhl IGNhbGxlciBhcwp0byB3aGV0aGVyIHRoZXkgcmlzayB0aGUgRklGTyBvdmVyZmxvd2luZywgYnV0 IHRoZXkgc2hvdWxkIGhhdmUgdGhlIHJpZ2h0CmluZm9ybWF0aW9uIHRvIGhhbmQuCi1DaHJpcwoK LS0gCkNocmlzIFdpbHNvbiwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50cmUKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==