From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 3/3] drm/i915: Only grab correct forcewake for the engine with execlists Date: Thu, 7 Apr 2016 15:59:40 +0100 Message-ID: <20160407145940.GI18061@nuc-i3427.alporthouse.com> References: <1460037940-14094-1-git-send-email-tvrtko.ursulin@linux.intel.com> <1460037940-14094-3-git-send-email-tvrtko.ursulin@linux.intel.com> <20160407142431.GE18061@nuc-i3427.alporthouse.com> <57067054.6090103@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id 5288D6E05C for ; Thu, 7 Apr 2016 15:00:05 +0000 (UTC) Content-Disposition: inline In-Reply-To: <57067054.6090103@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMDcsIDIwMTYgYXQgMDM6MzY6MDRQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gCj4gT24gMDcvMDQvMTYgMTU6MjQsIENocmlzIFdpbHNvbiB3cm90ZToKPiA+T24g VGh1LCBBcHIgMDcsIDIwMTYgYXQgMDM6MDU6NDBQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4gd3Jv dGU6Cj4gPj5AQCAtMjA5OSw2ICsyMTAxLDEyIEBAIGxvZ2ljYWxfcmluZ19pbml0KHN0cnVjdCBk cm1fZGV2aWNlICpkZXYsIHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiA+Pgo+ID4+ ICAJbG9naWNhbF9yaW5nX2luaXRfcGxhdGZvcm1faW52YXJpYW50cyhlbmdpbmUpOwo+ID4+Cj4g Pj4rCWVuZ2luZS0+ZndfZG9tYWluc19lbHNwID0KPiA+PisJCWludGVsX3JlZ193cml0ZV9md19k b21haW5zKGRldl9wcml2LCBSSU5HX0VMU1AoZW5naW5lKSk7Cj4gPj4rCWVuZ2luZS0+ZndfZG9t YWluc19jc2IgPQo+ID4+KwkJaW50ZWxfcmVnX3dyaXRlX2Z3X2RvbWFpbnMoZGV2X3ByaXYsCj4g Pj4rCQkJCQkgICBSSU5HX0NPTlRFWFRfU1RBVFVTX1BUUihlbmdpbmUpKTsKPiA+Cj4gPlNvIGlz IHdyaXRlIGEgc3VwZXJzZXQgb2YgZnc/IFRlbmRzIHRvIGJlIHJlYWRzIHRoYXQgcmVxdWlyZSBm dyBtb3JlCj4gPnRoYW4gd3JpdGVzIChnZW42LzcgZmlmbywgZ2VuOCB3cml0ZSBzaGFkb3dpbmcp Lgo+ID4KPiA+SSB0aGluayB3ZSBuZWVkIGEgUkVBRCB8IFdSSVRFIGRpcmVjdGlvbiBmaWVsZC4K PiAKPiBIbSwgeWVzIGVtYmVkZGluZyB0b28gbXVjaCBrbm93bGVkZ2UgaW4gdGhlIGNhbGxlciwg aG93IGFib3V0IGp1c3Q6Cj4gCj4gCWVuZ2luZS0+ZndfZG9tYWluc19jc2IgPSBpbnRlbF9yZWdf cmVhZF9md19kb21haW5zKGRldl9wcml2LAo+IAkJCQkgUklOR19DT05URVhUX1NUQVRVU19QVFIo ZW5naW5lKSk7Cj4gCj4gCWVuZ2luZS0+ZndfZG9tYWluc19jc2IgfD0gaW50ZWxfcmVnX3dyaXRl X2Z3X2RvbWFpbnMoZGV2X3ByaXYsCj4gCQkJCSAgUklOR19DT05URVhUX1NUQVRVU19QVFIoZW5n aW5lKSk7CgpTZWUgbXkgb3RoZXIgbWFpbCBmb3IgYSBtb2NrdXAgb2Ygc29tZSBjb2RlLiBTb21l dGhpbmcgYWxvbmcgdGhlc2UKbGluZXMuCgo+ID4+Ky8qKgo+ID4+KyAqIGludGVsX3JlZ193cml0 ZV9md19kb21haW5zIC0gd2hpY2ggZm9yY2V3YWtlIGRvbWFpbnMgYXJlIG5lZWRlZCB0byB3cml0 ZSBhIHJlZ2lzdGVyCj4gPj4rICogQGRldl9wcml2OiBwb2ludGVyIHRvIHN0cnVjdCBkcm1faTkx NV9wcml2YXRlCj4gPj4rICogQHJlZzogcmVnaXN0ZXIgaW4gcXVlc3Rpb24KPiA+PisgKgo+ID4+ KyAqIFJldHVybnMgYSBzZXQgb2YgZm9yY2V3YWtlIGRvbWFpbnMgcmVxdWlyZWQgdG8gYmUgdGFr ZW4gd2l0aCBmb3IgZXhhbXBsZQo+ID4+KyAqIGludGVsX3VuY29yZV9mb3JjZXdha2VfZ2V0IGZv ciB0aGUgc3BlY2lmaWVkIHJlZ2lzdGVyIHRvIGJlIHdyaXRhYmxlIHdpdGggdGhlCj4gPj4rICog cmF3IG1taW8gYWNjZXNzb3JzLgo+ID4+KyAqLwo+ID4+K2VudW0gZm9yY2V3YWtlX2RvbWFpbnMK PiA+PitpbnRlbF9yZWdfd3JpdGVfZndfZG9tYWlucyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYsIGk5MTVfcmVnX3QgcmVnKQo+ID4+K3sKPiA+PisJZW51bSBmb3JjZXdha2VfZG9t YWlucyBmd19kb21haW5zOwo+ID4+Kwo+ID4+KwlpZiAoaW50ZWxfdmdwdV9hY3RpdmUoZGV2X3By aXYtPmRldikpCj4gPj4rCQlyZXR1cm4gMDsKPiA+PisKPiA+PisJc3dpdGNoIChJTlRFTF9JTkZP KGRldl9wcml2KS0+Z2VuKSB7Cj4gPj4rCWNhc2UgOToKPiA+PisJCWZ3X2RvbWFpbnMgPSBfX2dl bjlfcmVnX3dyaXRlX2Z3X2RvbWFpbnMoaTkxNV9tbWlvX3JlZ19vZmZzZXQocmVnKSk7Cj4gPj4r CQlicmVhazsKPiA+PisJY2FzZSA4Ogo+ID4+KwkJaWYgKElTX0NIRVJSWVZJRVcoZGV2X3ByaXYp KQo+ID4+KwkJCWZ3X2RvbWFpbnMgPSBfX2Nodl9yZWdfd3JpdGVfZndfZG9tYWlucyhpOTE1X21t aW9fcmVnX29mZnNldChyZWcpKTsKPiA+PisJCWVsc2UKPiA+PisJCQlmd19kb21haW5zID0gX19n ZW44X3JlZ193cml0ZV9md19kb21haW5zKGk5MTVfbW1pb19yZWdfb2Zmc2V0KHJlZykpOwo+ID4+ KwkJYnJlYWs7Cj4gPj4rCWRlZmF1bHQ6Cj4gPj4rCQlNSVNTSU5HX0NBU0UoSU5URUxfSU5GTyhk ZXZfcHJpdiktPmdlbik7Cj4gPj4rCWNhc2UgNzoKPiA+PisJY2FzZSA2Ogo+ID4KPiA+VGhpcyBp cyBhY3R1YWxseSBhIHRyaWNreSBvbmUuIGdlbjYvNyBtYWludGFpbiBhIEZJRk8gdG8gc3RvcmUg bW1pbwo+ID53cml0ZXMgd2hpbHN0IGl0IGlzIHBvd2VyZWQgZG93bi4gSWYgd2UgZmlsbCB0aGF0 IGZpZm8gd2UgZHJvcCB3cml0ZXMKPiA+KGFuZCB0aGF0IGZpZm8gaXMgc2hhcmVkIHdpdGggZnVu Y3Rpb25zIG9uIHRoZSBkZXZpY2UsIGkuZS4gaXQgaXMgbm90Cj4gPm91cnMgdG8gZmlsbCBleGNs dXNpdmVseSkuIFNvIHNob3VsZCB3ZSBiZSBzYXZpbmcgdGhhdCBpZiB5b3Ugd2FudCB0bwo+ID5t YWtlIGxvdHMgb2Ygd3JpdGVzIHlvdSBzaG91bGQgdGFrZSB0aGlzIGZvcmNld2FrZSBkb21haW4u IFllcy4gV2Ugc2hvdWxkCj4gPnJlcG9ydCB3aGF0IGRvbWFpbnMgdGhleSB3b3VsZCByZXF1aXJl LCBpdCBpcyBzdGlsbCB1cCB0byB0aGUgY2FsbGVyIGFzCj4gPnRvIHdoZXRoZXIgdGhleSByaXNr IHRoZSBGSUZPIG92ZXJmbG93aW5nLCBidXQgdGhleSBzaG91bGQgaGF2ZSB0aGUgcmlnaHQKPiA+ aW5mb3JtYXRpb24gdG8gaGFuZC4KPiAKPiBNaXNzZWQgdGhhdC4gQnV0IGl0IGlzbid0IHBhcnQg b2YgZm9yY2V3YWtlIGRvbWFpbnMuIFNvIHdoYXQgd291bGQKPiB5b3UgcmV0dXJuPyBGYWtlIG91 dCBhIG5ldyBkb21haW4ganVzdCBjb21wbGljYXRlcyB0aGluZ3MgYW5kIGFkZHMKPiBjb3N0IGZv ciBldmVyeW9uZS4gTWF5YmUgYmV0dGVyIGp1c3QgdG8gbGltaXQgdGhlIHdob2xlIHRoaW5nIHRv Cj4gZ2VuOCsgYW5kIGxlYXZlIG9sZGVycyBwbGF0Zm9ybXMgdW50b3VjaGVkPwoKSXQgaXMgdGhl IEZPUkNFV0FLRV9SRU5ERVIgdG8gZmx1c2ggdGhlIHdyaXRlIEZJRk8sIGl0IGlzIGp1c3Qgbm90 IGNsZWFyCmluIHRoZSBpbXBsZW1lbnRhdGlvbiAoaS5lLiB3ZSBoYXZlIG5ldmVyIGRvbmUgdGhh dCBleHBsaWNpdGx5IC0gSSBkbwpyZW1lbWJlciBhdCBvZGQgdGltZXMgY291bnRpbmcgcmVnaXN0 ZXIgd3JpdGVzIHRob3VnaC4uLikuIE9ubHkgaW4gYSBmZXcKcGxhY2VzIChvdmVyIHJpbmcgaW5p dCkgaGF2ZSB3ZSBleHBsaWNpdGx5IHRha2VuIHRoZSBmdyBkb21haW4gYWNyb3NzIHdyaXRlcy4K CkknbSBsZWFuaW5nIHRvd2FyZHMgcmVwb3J0aW5nIHRoYXQgdGhleSBkbyByZXF1aXJlIHRoZSBk b21haW4sIHdpdGggYQpub3RlIHNheWluZyBhYm91dCB0aGUgZmlmby4gSXQgaXMgYSBzcGVjaWFs aXplZCBpbnRlcmZhY2UgYWZ0ZXIgYWxsIHRoYXQKaXMgZ29pbmcgdG8gYmUgdXNpbmcgaW4gZmFp cmx5IGdlbi1zcGVjaWZpYyBwYXRocyAoYW5kIGVycmluZyBvbiB0aGUKc2lkZSBvZiBjYXV0aW9u IHdoZW4gdXNlZCBvdXRzaWRlIG9mIHRoYXQgaXMgd2lzZSkuCi1DaHJpcwoKLS0gCkNocmlzIFdp bHNvbiwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50cmUKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==