From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoRXV-0004nN-Fp for qemu-devel@nongnu.org; Fri, 08 Apr 2016 04:13:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoRXS-0000mi-9m for qemu-devel@nongnu.org; Fri, 08 Apr 2016 04:13:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47640) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoRXS-0000mV-5A for qemu-devel@nongnu.org; Fri, 08 Apr 2016 04:13:10 -0400 Date: Fri, 8 Apr 2016 10:13:02 +0200 From: Igor Mammedov Message-ID: <20160408101302.240a177c@nial.brq.redhat.com> In-Reply-To: <20160408105013-mutt-send-email-mst@redhat.com> References: <1459733876-22908-1-git-send-email-stefanb@us.ibm.com> <20160404120420-mutt-send-email-mst@redhat.com> <5702428E.4050306@linux.vnet.ibm.com> <20160404141105.54fe30a5@igors-macbook-pro.local> <20160408105013-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] acpi: tpm: Fix TPM ACPI description List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Stefan Berger , Stefan Berger , crobinso@redhat.com, qemu-devel@nongnu.org On Fri, 8 Apr 2016 10:51:30 +0300 "Michael S. Tsirkin" wrote: > On Mon, Apr 04, 2016 at 02:11:05PM +0200, Igor Mammedov wrote: > > On Mon, 4 Apr 2016 06:31:43 -0400 > > Stefan Berger wrote: > > > > > On 04/04/2016 05:04 AM, Michael S. Tsirkin wrote: > > > > On Sun, Apr 03, 2016 at 09:37:54PM -0400, Stefan Berger wrote: > > > >> This series of patches fixes some problems with the TPM's ACPI > > > >> description. > > > > Could you pls describe how does this interact with Igor's patch? > > > > > > Follow https://bugzilla.redhat.com/attachment.cgi?id=1137429 and > > > attachment https://bugzilla.redhat.com/attachment.cgi?id=1137429 I > > > don't think we need Igor's patch. I am posting what has been tested. > > I've also tested my patch + commented out irq, it also 'works'. > > i.e. Windows doesn't see irq conflict as well. > > Igor, could you please post a complete patchset for testing? > It seems preferable to me. Ok, I'll post a2 patches, 1st adding range to PCI0._CRS and 2nd commenting out IRQ entry with a hope that Stefan will fix IRQ handling in 2.7 dev cycle. > > > > > > > > > > > > > > > >> Stefan Berger (2): > > > >> acpi: tpm: Fix TPM ACPI description (BZ 1281413) > > > >> acpi: tpm: Get the interrupt the device model is using > > > >> > > > >> hw/i386/acpi-build.c | 29 ++++++++++++++--------------- > > > >> hw/tpm/tpm_tis.c | 5 ++++- > > > >> include/sysemu/tpm.h | 6 +++--- > > > >> 3 files changed, 21 insertions(+), 19 deletions(-) > > > >> > > > >> -- > > > >> 2.5.5 > > >