[iptables PATCH] configure: exit if libnftnl is not found

[iptables PATCH] configure: exit if libnftnl is not found

[Giuseppe Longo]

iptables building is broken if libnftnl is not installed
on the system, raising up the following errors:

nft-shared.c:25:27: fatal error: libnftnl/rule.h: No such file or directory
 #include <libnftnl/rule.h>
                           ^
compilation terminated.
nft.c:41:28: fatal error: libnftnl/table.h: No such file or directory
 #include <libnftnl/table.h>
                            ^
compilation terminated.
mv -f .deps/xtables_multi-iptables-restore.Tpo .deps/xtables_multi-iptables-restore.Po
In file included from nft.h:5:0,
                 from nft-ipv6.c:25:
nft-shared.h:6:27: fatal error: libnftnl/rule.h: No such file or directory
 #include <libnftnl/rule.h>
                           ^
mv -f .deps/xtables_multi-xshared.Tpo .deps/xtables_multi-xshared.Po
compilation terminated.
In file included from nft.h:5:0,
                 from nft-ipv4.c:26:
nft-shared.h:6:27: fatal error: libnftnl/rule.h: No such file or directory
 #include <libnftnl/rule.h>

configure script checks if libnftnl is installed, but doesn't
exit if it is not.

Signed-off-by: Giuseppe Longo <giuseppelng@gmail.com>
---
 configure.ac | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/configure.ac b/configure.ac
index 33a8f2d..b08ecca 100644
--- a/configure.ac
+++ b/configure.ac
@@ -128,6 +128,13 @@ if test "x$enable_nftables" = "xyes"; then
 
 	PKG_CHECK_MODULES([libnftnl], [libnftnl >= 1.0.5], [nftables=1], [nftables=0])
 
+	if test "$nftables" = 0;
+	then
+		echo "*** Error: No suitable libnftnl found. ***"
+		echo "    Please install the 'libnftnl' package."
+		exit 1
+	fi
+
 	AM_PROG_LEX
 	AC_PROG_YACC
 
-- 
2.5.0

Re: [iptables PATCH] configure: exit if libnftnl is not found

[Jan Engelhardt]

On Sunday 2016-03-27 12:05, Giuseppe Longo wrote:
>+++ b/configure.ac
>@@ -128,6 +128,13 @@ if test "x$enable_nftables" = "xyes"; then
> 
> 	PKG_CHECK_MODULES([libnftnl], [libnftnl >= 1.0.5], [nftables=1], [nftables=0])
> 
>+	if test "$nftables" = 0;
>+	then
>+		echo "*** Error: No suitable libnftnl found. ***"
>+		echo "    Please install the 'libnftnl' package."
>+		exit 1
>+	fi
>+

This is totally unnecessary. Just remove the 3rd and 4th argument from the
PKG_CHECK_MODULES call immediately preceding it if libnftnl has become
a hard requirement.

Re: [iptables PATCH] configure: exit if libnftnl is not found

[Jan Engelhardt]

On Sunday 2016-03-27 21:56, Giuseppe Longo wrote:
>> >+++ b/configure.ac
>> >@@ -128,6 +128,13 @@ if test "x$enable_nftables" = "xyes"; then
>> >
>> >       PKG_CHECK_MODULES([libnftnl], [libnftnl >= 1.0.5], [nftables=1],
>[nftables=0])
>> >
>> >+      if test "$nftables" = 0;
>> >+      then
>> >+              echo "*** Error: No suitable libnftnl found. ***"
>> >+              echo "    Please install the 'libnftnl' package."
>> >+              exit 1
>> >+      fi
>>
>> This is unnecessary. Just remove the 3rd and 4th argument from the
>> PKG_CHECK_MODULES call.
>
>We may use the 3rd argument instead of remove it.

What good would that do? If you abolish the nftables=0 case,
then everything else becomes 'always-nftables' and
[nftables=1] would be redundant to mention.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [iptables PATCH] configure: exit if libnftnl is not found

[Pablo Neira Ayuso]

On Sun, Mar 27, 2016 at 12:05:46PM +0200, Giuseppe Longo wrote:
> iptables building is broken if libnftnl is not installed
> on the system, raising up the following errors:
> 
> nft-shared.c:25:27: fatal error: libnftnl/rule.h: No such file or directory
>  #include <libnftnl/rule.h>
>                            ^
> compilation terminated.
> nft.c:41:28: fatal error: libnftnl/table.h: No such file or directory
>  #include <libnftnl/table.h>
>                             ^
> compilation terminated.
> mv -f .deps/xtables_multi-iptables-restore.Tpo .deps/xtables_multi-iptables-restore.Po
> In file included from nft.h:5:0,
>                  from nft-ipv6.c:25:
> nft-shared.h:6:27: fatal error: libnftnl/rule.h: No such file or directory
>  #include <libnftnl/rule.h>
>                            ^
> mv -f .deps/xtables_multi-xshared.Tpo .deps/xtables_multi-xshared.Po
> compilation terminated.
> In file included from nft.h:5:0,
>                  from nft-ipv4.c:26:
> nft-shared.h:6:27: fatal error: libnftnl/rule.h: No such file or directory
>  #include <libnftnl/rule.h>
> 
> configure script checks if libnftnl is installed, but doesn't
> exit if it is not.
> 
> Signed-off-by: Giuseppe Longo <giuseppelng@gmail.com>
> ---
>  configure.ac | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index 33a8f2d..b08ecca 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -128,6 +128,13 @@ if test "x$enable_nftables" = "xyes"; then
>  
>  	PKG_CHECK_MODULES([libnftnl], [libnftnl >= 1.0.5], [nftables=1], [nftables=0])
>  
> +	if test "$nftables" = 0;
> +	then
> +		echo "*** Error: No suitable libnftnl found. ***"
> +		echo "    Please install the 'libnftnl' package."

I'm going to take this patch, but mangle it to include this information too:

		echo "    Or consider --disable-nftables to skip "
                echo "    iptables-compat over nftables support."

Re: [iptables PATCH] configure: exit if libnftnl is not found

[Giuseppe Longo]

Hi Pablo,

2016-04-08 14:55 GMT+02:00 Pablo Neira Ayuso <pablo@netfilter.org>:
> On Sun, Mar 27, 2016 at 12:05:46PM +0200, Giuseppe Longo wrote:
>> iptables building is broken if libnftnl is not installed
>> on the system, raising up the following errors:
>>
>> nft-shared.c:25:27: fatal error: libnftnl/rule.h: No such file or directory
>>  #include <libnftnl/rule.h>
>>                            ^
>> compilation terminated.
>> nft.c:41:28: fatal error: libnftnl/table.h: No such file or directory
>>  #include <libnftnl/table.h>
>>                             ^
>> compilation terminated.
>> mv -f .deps/xtables_multi-iptables-restore.Tpo .deps/xtables_multi-iptables-restore.Po
>> In file included from nft.h:5:0,
>>                  from nft-ipv6.c:25:
>> nft-shared.h:6:27: fatal error: libnftnl/rule.h: No such file or directory
>>  #include <libnftnl/rule.h>
>>                            ^
>> mv -f .deps/xtables_multi-xshared.Tpo .deps/xtables_multi-xshared.Po
>> compilation terminated.
>> In file included from nft.h:5:0,
>>                  from nft-ipv4.c:26:
>> nft-shared.h:6:27: fatal error: libnftnl/rule.h: No such file or directory
>>  #include <libnftnl/rule.h>
>>
>> configure script checks if libnftnl is installed, but doesn't
>> exit if it is not.
>>
>> Signed-off-by: Giuseppe Longo <giuseppelng@gmail.com>
>> ---
>>  configure.ac | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 33a8f2d..b08ecca 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -128,6 +128,13 @@ if test "x$enable_nftables" = "xyes"; then
>>
>>       PKG_CHECK_MODULES([libnftnl], [libnftnl >= 1.0.5], [nftables=1], [nftables=0])
>>
>> +     if test "$nftables" = 0;
>> +     then
>> +             echo "*** Error: No suitable libnftnl found. ***"
>> +             echo "    Please install the 'libnftnl' package."
>
> I'm going to take this patch, but mangle it to include this information too:
>
>                 echo "    Or consider --disable-nftables to skip "
>                 echo "    iptables-compat over nftables support."
>

I can send a v2 of this patch with these changes.
I think a similar patch is needed for libmnl because
there is a same issue.

Re: [iptables PATCH] configure: exit if libnftnl is not found

[Pablo Neira Ayuso]

On Sat, Apr 09, 2016 at 10:46:40AM +0200, Giuseppe Longo wrote:
> >> @@ -128,6 +128,13 @@ if test "x$enable_nftables" = "xyes"; then
> >>
> >>       PKG_CHECK_MODULES([libnftnl], [libnftnl >= 1.0.5], [nftables=1], [nftables=0])
> >>
> >> +     if test "$nftables" = 0;
> >> +     then
> >> +             echo "*** Error: No suitable libnftnl found. ***"
> >> +             echo "    Please install the 'libnftnl' package."
> >
> > I'm going to take this patch, but mangle it to include this information too:
> >
> >                 echo "    Or consider --disable-nftables to skip "
> >                 echo "    iptables-compat over nftables support."
> >
> 
> I can send a v2 of this patch with these changes.
> I think a similar patch is needed for libmnl because
> there is a same issue.

Fine with me, I'd appreciate if you send a v2. Thanks!