From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758489AbcDHNHl (ORCPT ); Fri, 8 Apr 2016 09:07:41 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35953 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758412AbcDHNHj (ORCPT ); Fri, 8 Apr 2016 09:07:39 -0400 Date: Fri, 8 Apr 2016 15:07:16 +0200 From: Michal Hocko To: Andrew Morton Cc: David Rientjes , Tetsuo Handa , linux-mm@kvack.org, LKML Subject: Re: [PATCH 3/3] mm, oom_reaper: clear TIF_MEMDIE for all tasks queued for oom_reaper Message-ID: <20160408130716.GI29820@dhcp22.suse.cz> References: <1459951996-12875-1-git-send-email-mhocko@kernel.org> <1459951996-12875-4-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459951996-12875-4-git-send-email-mhocko@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew, could you please fold this in? --- >>From 4e23df3584966f6d7885245f3071c15669b8a5fc Mon Sep 17 00:00:00 2001 From: Michal Hocko Date: Fri, 8 Apr 2016 15:04:29 +0200 Subject: [PATCH] mm, oom_reaper: clear oom_reaper_list before clearing TIF_MEMDIE As per Tetsuo: : oom_reaper() will need to do "tsk->oom_reaper_list = NULL;" due to : : if (tsk == oom_reaper_list || tsk->oom_reaper_list) : return; : : test in wake_oom_reaper() if "[PATCH 3/3] mm, oom_reaper: clear : TIF_MEMDIE for all tasks queued for oom_reaper" will select the same : thread again Signed-off-by: Michal Hocko --- mm/oom_kill.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 7098104b7475..ca34036f3ae1 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -540,6 +540,7 @@ static void oom_reap_task(struct task_struct *tsk) * for the oom victim right now because it cannot release its memory * itself nor by the oom reaper. */ + tsk->oom_reaper_list = NULL; exit_oom_victim(tsk); /* Drop a reference taken by wake_oom_reaper */ -- 2.8.0.rc3 -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by kanga.kvack.org (Postfix) with ESMTP id 2E2286B007E for ; Fri, 8 Apr 2016 09:07:20 -0400 (EDT) Received: by mail-wm0-f47.google.com with SMTP id l6so64003250wml.1 for ; Fri, 08 Apr 2016 06:07:20 -0700 (PDT) Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com. [74.125.82.68]) by mx.google.com with ESMTPS id u72si2905160wmd.93.2016.04.08.06.07.18 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Apr 2016 06:07:19 -0700 (PDT) Received: by mail-wm0-f68.google.com with SMTP id n3so4251517wmn.1 for ; Fri, 08 Apr 2016 06:07:18 -0700 (PDT) Date: Fri, 8 Apr 2016 15:07:16 +0200 From: Michal Hocko Subject: Re: [PATCH 3/3] mm, oom_reaper: clear TIF_MEMDIE for all tasks queued for oom_reaper Message-ID: <20160408130716.GI29820@dhcp22.suse.cz> References: <1459951996-12875-1-git-send-email-mhocko@kernel.org> <1459951996-12875-4-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459951996-12875-4-git-send-email-mhocko@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: David Rientjes , Tetsuo Handa , linux-mm@kvack.org, LKML Andrew, could you please fold this in? ---