From: Neil Horman <nhorman@tuxdriver.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Seth Heasley <seth.heasley@intel.com>,
scott.lawson@intel.com, alexandra.yates@intel.com,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2] i2c: ismt: Add Intel DNV PCI ID
Date: Fri, 8 Apr 2016 10:17:15 -0400 [thread overview]
Message-ID: <20160408141715.GC11476@hmsreliant.think-freely.org> (raw)
In-Reply-To: <1460119268-23338-1-git-send-email-mika.westerberg@linux.intel.com>
On Fri, Apr 08, 2016 at 03:41:08PM +0300, Mika Westerberg wrote:
> Intel DNV has the same iSMT SMBus host controller than Intel Avoton. Add
> DNV PCI ID to the list of supported devices.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> Wolfram,
>
> This is the same patch that conflicted with another patch by Alexandra [1].
> We have now verified that it is the iSMT driver that is compatible with
> this particular PCI ID (not i2c-i801.c). Not tested on a real hardware as I
> do not have such machine available.
>
> v2: Order PCI IDs by their value
>
> [1] https://patchwork.ozlabs.org/patch/584758/
>
> drivers/i2c/busses/i2c-ismt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
> index 7ba795b24e75..1c8707710098 100644
> --- a/drivers/i2c/busses/i2c-ismt.c
> +++ b/drivers/i2c/busses/i2c-ismt.c
> @@ -75,6 +75,7 @@
> /* PCI DIDs for the Intel SMBus Message Transport (SMT) Devices */
> #define PCI_DEVICE_ID_INTEL_S1200_SMT0 0x0c59
> #define PCI_DEVICE_ID_INTEL_S1200_SMT1 0x0c5a
> +#define PCI_DEVICE_ID_INTEL_DNV_SMT 0x19ac
> #define PCI_DEVICE_ID_INTEL_AVOTON_SMT 0x1f15
>
> #define ISMT_DESC_ENTRIES 2 /* number of descriptor entries */
> @@ -180,6 +181,7 @@ struct ismt_priv {
> static const struct pci_device_id ismt_ids[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_S1200_SMT0) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_S1200_SMT1) },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMT) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_AVOTON_SMT) },
> { 0, }
> };
> --
> 2.8.0.rc3
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
next prev parent reply other threads:[~2016-04-08 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 12:41 [PATCH v2] i2c: ismt: Add Intel DNV PCI ID Mika Westerberg
2016-04-08 14:17 ` Neil Horman [this message]
2016-04-12 21:45 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160408141715.GC11476@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=alexandra.yates@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=scott.lawson@intel.com \
--cc=seth.heasley@intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.